* [PATCH] Let check_preimage() use memset() to initialize "struct checkout"
@ 2010-04-09 20:08 Jens Lehmann
0 siblings, 0 replies; only message in thread
From: Jens Lehmann @ 2010-04-09 20:08 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List
Every code site except check_preimage() uses either memset() or declares
a static instance of "struct checkout" to achieve proper initialization.
Lets use memset() instead of explicit initialization of all members here
too to be on the safe side in case this structure is expanded someday.
Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---
builtin/apply.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index ec755ac..d56cabf 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -2821,11 +2821,8 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s
if (stat_ret < 0) {
struct checkout costate;
/* checkout */
+ memset(&costate, 0, sizeof(costate));
costate.base_dir = "";
- costate.base_dir_len = 0;
- costate.force = 0;
- costate.quiet = 0;
- costate.not_new = 0;
costate.refresh_cache = 1;
if (checkout_entry(*ce, &costate, NULL) ||
lstat(old_name, st))
--
1.7.0.3.517.g0017
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-09 20:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-09 20:08 [PATCH] Let check_preimage() use memset() to initialize "struct checkout" Jens Lehmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).