git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [WIP PATCH 4/4] Teach checkout-index to recursively checkout submodules
Date: Sat, 10 Apr 2010 01:22:42 +0200	[thread overview]
Message-ID: <4BBFB6C2.1090506@web.de> (raw)
In-Reply-To: <7v8w8w1dwl.fsf@alter.siamese.dyndns.org>

Am 10.04.2010 00:04, schrieb Junio C Hamano:
> As a plumbing I would prefer to leave checkout-index as is; script writers
> can choose to recurse if they choose to.

O.k.; what about adding an option "--recurse-submodules" to activate that
behavior - without having to code it every time - when wanted?


> This is not limited to checkout-index, but what is the stance of this new
> feature on failures from sub-checkout when there are local modifications
> in the work tree?  Some parts of the work tree is checked out while the
> ones after the failure that sorts later in the alphabetical order will not
> be checked out, resulting in an inconsistent state (I am not saying that
> it is good or bad---I am trying to see what the users should expect from
> this new feature)?

I would like to see the same attitude that checkout has on local files:
Don't overwrite anything changed (unless forced to). And an inconsistent
state should never happen, the checks on the submodules should be done
before the first file or submodule is checked out (But i still have to
test and verify that behavior in yet to be added tests).

  reply	other threads:[~2010-04-09 23:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 21:34 [WIP PATCH 0/4] Recursively checkout submodules Jens Lehmann
2010-04-09 21:36 ` [WIP PATCH 1/4] Prepare checkout_entry() for recursive checkout of submodules Jens Lehmann
2010-04-09 21:59   ` Junio C Hamano
2010-04-09 23:11     ` Jens Lehmann
2010-04-10 17:01       ` Jens Lehmann
2010-04-10 18:44         ` Junio C Hamano
2010-04-10 20:57           ` Jens Lehmann
2010-04-09 21:37 ` [WIP PATCH 2/4] Add "ignore_submodules" member to "struct unpack_trees_options" Jens Lehmann
2010-04-09 21:39 ` [WIP PATCH 3/4] Teach checkout to recursively checkout submodules Jens Lehmann
2010-04-09 21:40 ` [WIP PATCH 4/4] Teach checkout-index " Jens Lehmann
2010-04-09 22:04   ` Junio C Hamano
2010-04-09 23:22     ` Jens Lehmann [this message]
2010-04-10  5:07 ` [WIP PATCH 0/4] Recursively " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBFB6C2.1090506@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).