git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] reflog: ignore expire-unreachable for "HEAD" reflog
Date: Fri, 16 Apr 2010 08:08:10 +0200	[thread overview]
Message-ID: <4BC7FECA.2010202@viscovery.net> (raw)
In-Reply-To: <20100415163607.GA4279@coredump.intra.peff.net>

Am 4/15/2010 18:36, schrieb Jeff King:
> I think it is because the reachability test is defined as "from the
> current ref".

Thanks, this clears my confusion. I see the problem that Junio wants to
fix, but IMHO this:

> I think another way of addressing the same problem would be to redefine
> "reachable" in this context as "reachable from any current ref".

would be a better approach for a fix rather than an exception for HEAD.

-- Hannes

  parent reply	other threads:[~2010-04-16  6:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14 20:34 [PATCH 1/2] Document gc.<pattern>.reflogexpire variables Junio C Hamano
2010-04-14 20:35 ` [PATCH 2/2] reflog: ignore expire-unreachable for "HEAD" reflog Junio C Hamano
2010-04-15  6:45   ` Johannes Sixt
2010-04-15  7:40     ` Junio C Hamano
2010-04-15  8:49       ` Johannes Sixt
2010-04-15 12:30         ` Junio C Hamano
2010-04-15 12:58           ` Johannes Sixt
2010-04-15 16:36             ` Jeff King
2010-04-15 16:57               ` Junio C Hamano
2010-04-15 19:48                 ` Nicolas Pitre
2010-04-15 22:42                   ` Junio C Hamano
2010-04-16  1:11                     ` Nicolas Pitre
2010-04-16  1:37                       ` Junio C Hamano
2010-04-16  3:07                         ` Nicolas Pitre
2010-04-16  6:08               ` Johannes Sixt [this message]
2010-04-15 16:49             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC7FECA.2010202@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).