From: Mark Rada <marada@uwaterloo.ca>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Improve installation instructions in gitweb/INSTALL
Date: Tue, 27 Apr 2010 16:40:11 -0400 [thread overview]
Message-ID: <4BD74BAB.1040401@mailservices.uwaterloo.ca> (raw)
In-Reply-To: <20100427203341.31445.82930.stgit@localhost.localdomain>
On 10-04-27 4:33 PM, Jakub Narebski wrote:
> + The above instruction assumes that you didn't use JavaScript
> + minimizer or CSS minimizer. If you use minimizers you need
> + to modify above instructions accordingly, which means pointing
> + GITWEB_CSS and GITWEB_JS to minified versions, and copying
> + minified files.
> +
>
Hmm, I believe I already put a message like this in the INSTALL
file. Perhaps that message should be updated, too, or removed in
place of your patch.
Looks like:
67
68 - You can optionally generate minified versions of gitweb.js and gitweb.css
69 by defining the JSMIN and CSSMIN build configuration variables. By default
70 the non-minified versions will be used. NOTE: if you enable this option,
71 substitute gitweb.min.js and gitweb.min.css for all uses of gitweb.js and
72 gitweb.css in the help files.
--
Mark Rada
marada@uwaterloo.ca
next prev parent reply other threads:[~2010-04-27 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 20:33 [PATCH] gitweb: Improve installation instructions in gitweb/INSTALL Jakub Narebski
2010-04-27 20:40 ` Mark Rada [this message]
2010-04-27 20:47 ` [PATCHv2] " Jakub Narebski
2010-04-27 22:27 ` Mark Rada
2010-04-27 20:40 ` [PATCH (amend)] " Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD74BAB.1040401@mailservices.uwaterloo.ca \
--to=marada@uwaterloo.ca \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).