From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: 1.7.2 cycle will open soon
Date: Thu, 06 May 2010 08:57:19 +0200 [thread overview]
Message-ID: <4BE2684F.1080004@viscovery.net> (raw)
In-Reply-To: <20100506055236.GA16151@coredump.intra.peff.net>
Am 5/6/2010 7:52, schrieb Jeff King:
> Why not just:
>
> test_run_ () {
> test_cleanup=
> eval >&3 2>&4 "$1"
> eval_ret=$?
> eval >&3 2>&4 "$test_cleanup"
> return 0
> }
>
> test_when_finished () {
> test_cleanup="$*; $test_cleanup"
> }
>
> Am I missing something?
I ask myself the same question.
For my taste, this change went production far too fast. Did I miss any
discussion on it? (I didn't speak up when it passed by on the ML because I
was on a short trip at that time.)
-- Hannes
prev parent reply other threads:[~2010-05-06 6:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 5:39 1.7.2 cycle will open soon Junio C Hamano
2010-05-06 5:52 ` Jeff King
2010-05-06 6:44 ` Jonathan Nieder
2010-05-06 6:54 ` Jeff King
2010-05-06 8:41 ` [PATCH] test-lib: some shells do not let $? propagate into an eval Jonathan Nieder
2010-05-06 8:57 ` Jeff King
2010-05-06 20:20 ` Junio C Hamano
2010-05-06 7:06 ` 1.7.2 cycle will open soon Johannes Sixt
2010-05-06 7:49 ` Jeff King
2010-05-06 8:01 ` Jonathan Nieder
2010-05-06 6:57 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE2684F.1080004@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).