From: Johannes Sixt <j.sixt@viscovery.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: 1.7.2 cycle will open soon
Date: Thu, 06 May 2010 09:06:43 +0200 [thread overview]
Message-ID: <4BE26A83.4010708@viscovery.net> (raw)
In-Reply-To: <20100506064428.GA29360@progeny.tock>
Am 5/6/2010 8:44, schrieb Jonathan Nieder:
> test_when_finished () {
> test_cleanup="$* && $test_cleanup"
> }
I'm wondering why you want this test_cleanup at all?
Is it so that subsequent tests can succeed even if an earlier test failed
before its regular cleanup?
I don't see what this buys you. If a test case uncovers a regression, you
got to fix it - who cares how many later tests fail or not? Once you are
finished with your change, all tests will pass anyway (including their
regular cleanups).
-- Hannes
next prev parent reply other threads:[~2010-05-06 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 5:39 1.7.2 cycle will open soon Junio C Hamano
2010-05-06 5:52 ` Jeff King
2010-05-06 6:44 ` Jonathan Nieder
2010-05-06 6:54 ` Jeff King
2010-05-06 8:41 ` [PATCH] test-lib: some shells do not let $? propagate into an eval Jonathan Nieder
2010-05-06 8:57 ` Jeff King
2010-05-06 20:20 ` Junio C Hamano
2010-05-06 7:06 ` Johannes Sixt [this message]
2010-05-06 7:49 ` 1.7.2 cycle will open soon Jeff King
2010-05-06 8:01 ` Jonathan Nieder
2010-05-06 6:57 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE26A83.4010708@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).