git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: SLONIK.AZ@gmail.com
Cc: Junio C Hamano <gitster@pobox.com>,
	Andy Parkins <andyparkins@gmail.com>,
	git@vger.kernel.org
Subject: Re: git-status and git-diff now very slow in project with a submodule
Date: Sat, 22 May 2010 14:08:38 +0200	[thread overview]
Message-ID: <4BF7C946.1040000@web.de> (raw)
In-Reply-To: <AANLkTilctjct-a911H14XMnaBydYR1I6lPbEuFThTJ99@mail.gmail.com>

Am 21.05.2010 14:52, schrieb Leo Razoumov:
> On 2010-05-20, Junio C Hamano <gitster@pobox.com> wrote:
> I would be interested to know of any counter-example: that is, a
> use-case where it makes logical sense to declare a repo dirty when it
> gets an untracked file not mentioned in .gitignore.

For submodules the presence of untracked files must be visible in the
superproject. When new files are added to a submodule but the user
forgot to commit them, the superproject might not even build at all
when another developer clones the superproject. And yes, this is a
real-life use case from my dayjob.

The alternative to these broader definitions about when to declare a
submodule dirty (new commits, modified content and untracked content)
would have been to handle all eight combinations of these states. In
all relevant parts of the toolchain. Which seems pretty insane. So
the submodule shows up as modified; and all but the short outputs of
diff and status also tell you /why/ it is considered modified. So the
user can decide what to do about that.

      parent reply	other threads:[~2010-05-22 12:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20 10:01 git-status and git-diff now very slow in project with a submodule Andy Parkins
2010-05-20 10:10 ` Stefan Naewe
2010-05-20 11:37   ` Andy Parkins
2010-05-20 15:52     ` Michael J Gruber
2010-05-20 17:45       ` Andy Parkins
2010-05-20 17:49         ` Jens Lehmann
2010-05-20 18:01           ` Andy Parkins
2010-05-21 12:36             ` Nguyen Thai Ngoc Duy
2010-05-20 13:28 ` Junio C Hamano
2010-05-20 17:17   ` Andy Parkins
2010-05-20 22:59     ` Junio C Hamano
2010-05-21 12:05       ` Jens Lehmann
2010-05-21 12:52   ` Leo Razoumov
2010-05-21 17:54     ` Andreas Schwab
2010-05-22 12:05       ` Jens Lehmann
2010-05-22 12:08     ` Jens Lehmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF7C946.1040000@web.de \
    --to=jens.lehmann@web.de \
    --cc=SLONIK.AZ@gmail.com \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).