From: Johannes Sixt <j.sixt@viscovery.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git@vger.kernel.org, gitster@pobox.com,
Brandon Casey <drafnel@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH 1/5] t/t5800: skip if python version is older than 2.5
Date: Wed, 02 Jun 2010 08:37:12 +0200 [thread overview]
Message-ID: <4C05FC18.4090402@viscovery.net> (raw)
In-Reply-To: <Wt_M4qptcPdpY0Q3jqUbfCU_HpY9NEjqs9eujZFD2rsUj5HRo__oQm7EUCxzXu38mC0y-ilUA14@cipher.nrlssc.navy.mil>
Am 6/2/2010 2:13, schrieb Brandon Casey:
> +if ! test_have_prereq PYTHON_2_5_OR_NEWER
> then
> + say 'skipping git remote-testgit tests: requires Python 2.5 or newer'
...
> +++ b/t/test-lib.sh
> +if test_have_prereq PYTHON && "$PYTHON_PATH" -c '
> +import sys
> +if sys.hexversion < 0x02050000:
> + sys.exit(1)
> +'
> +then
> + test_set_prereq PYTHON_2_5_OR_NEWER
> +fi
Please don't burden all test script invocations with this check when the
result is used in only one place.
-- Hannes
next prev parent reply other threads:[~2010-06-02 6:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 0:13 [PATCH 0/5] miscellaneous test suite fixes Brandon Casey
2010-06-02 0:13 ` [PATCH 1/5] t/t5800: skip if python version is older than 2.5 Brandon Casey
2010-06-02 6:21 ` Sverre Rabbelier
2010-06-02 9:33 ` Ævar Arnfjörð Bjarmason
2010-06-02 14:44 ` Brandon Casey
2010-06-02 15:15 ` Brandon Casey
2010-06-02 16:38 ` Sverre Rabbelier
2010-06-02 16:50 ` Brandon Casey
2010-06-02 23:23 ` test suite work-around for python 2.5 requirement Brandon Casey
2010-06-02 23:23 ` [PATCH 1/2] Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS Brandon Casey
2010-06-02 23:23 ` [PATCH 2/2] t/t5800: skip if python version is older than 2.5 Brandon Casey
2010-08-17 23:15 ` Sverre Rabbelier
2010-08-17 23:28 ` Jonathan Nieder
2010-08-17 23:32 ` Sverre Rabbelier
2010-08-17 23:37 ` Jonathan Nieder
2010-08-18 0:10 ` Sverre Rabbelier
2010-08-18 2:37 ` Brandon Casey
2010-06-02 6:37 ` Johannes Sixt [this message]
2010-06-02 14:46 ` [PATCH 1/5] " Brandon Casey
2010-06-02 0:13 ` [PATCH 2/5] git-request-pull.sh: remove -e switch to shell interpreter which breaks ksh Brandon Casey
2010-06-02 4:30 ` Jonathan Nieder
2010-06-02 14:21 ` Brandon Casey
2010-06-02 23:37 ` Junio C Hamano
2010-06-02 0:13 ` [PATCH 3/5] t/t5150: remove space from sed script Brandon Casey
2010-06-02 4:12 ` Jonathan Nieder
2010-06-02 0:13 ` [PATCH 4/5] t/t7006: ignore return status of shell's unset builtin Brandon Casey
2010-06-02 5:47 ` Jonathan Nieder
2010-06-02 6:41 ` Johannes Sixt
2010-06-02 14:47 ` Brandon Casey
2010-06-02 15:32 ` [PATCH 4/5 v2] " Brandon Casey
2010-06-02 0:13 ` [PATCH 5/5] t/aggregate-results: accomodate systems with small max argument list length Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C05FC18.4090402@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).