From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org
Subject: Re: [PATCH 0/4] Don't warn about missing EOL for symlinks
Date: Fri, 04 Jun 2010 16:15:32 +0200 [thread overview]
Message-ID: <4C090A84.20209@kdbg.org> (raw)
In-Reply-To: <20100603170724.GB22779@coredump.intra.peff.net>
Am 03.06.2010 19:07, schrieb Jeff King:
> I don't think "but they should be using plumbing to generate patches"
> is the right answer, either. Yes, we expect the diff porcelain to behave
> differently depending on configuration, but with the exception of
> textconv, it always produces an actual applicable patch.
I don't by into that argument: You have to give --binary if you have
changes in binary files. With Michael's patch, you have to give
--no-textonv (too). I'm in favor of the patch.
-- Hannes
next prev parent reply other threads:[~2010-06-04 14:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 14:35 [PATCH 0/4] Don't warn about missing EOL for symlinks Michael J Gruber
2010-06-03 14:35 ` [PATCH 1/4] diff/xdiff: refactor EOF-EOL detection Michael J Gruber
2010-06-03 21:58 ` Junio C Hamano
2010-06-04 7:38 ` Michael J Gruber
2010-06-05 6:38 ` Junio C Hamano
2010-06-05 18:58 ` Michael J Gruber
2010-06-06 22:03 ` Jeff King
2010-06-06 4:00 ` Junio C Hamano
2010-06-06 9:01 ` Johannes Sixt
2010-06-06 22:08 ` Jeff King
2010-06-07 8:10 ` Michael J Gruber
2010-06-03 14:35 ` [PATCH 2/4] diff: make treatment of missing EOL at EOF configurable Michael J Gruber
2010-06-03 14:35 ` [PATCH 3/4] diff: Do not warn about missing EOL at EOF for symlinks Michael J Gruber
2010-06-03 17:02 ` Jeff King
2010-06-03 14:35 ` [PATCH 4/4] RFC: add whitespace rule for no-eol-at-eof Michael J Gruber
2010-06-03 14:47 ` [PATCH 0/4] Don't warn about missing EOL for symlinks Matthieu Moy
2010-06-03 14:57 ` Michael J Gruber
2010-06-03 17:07 ` Jeff King
2010-06-03 19:55 ` Michael J Gruber
2010-06-03 20:17 ` Jeff King
2010-06-04 14:15 ` Johannes Sixt [this message]
2010-06-04 15:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C090A84.20209@kdbg.org \
--to=j6t@kdbg.org \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).