git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: A Large Angry SCM <gitzilla@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
	Nicolas Pitre <nico@fluxnic.net>,
	Scott Chacon <schacon@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: Git sideband hook output
Date: Fri, 11 Jun 2010 17:55:28 -0400	[thread overview]
Message-ID: <4C12B0D0.9000805@gmail.com> (raw)
In-Reply-To: <AANLkTikONJoDiyxmcmdG8zZkTCLbqXlXhrASae7rAreN@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> On Thu, Jun 10, 2010 at 18:30, Shawn O. Pearce <spearce@spearce.org> wrote:
>> Peter Kjellerstedt <peter.kjellerstedt@axis.com> wrote:
>>> And what if my hook output is localized? Now there is an English
>>> "remote:" in front of every line... Or even worse, what if the
>>> "remote:" string is localized in a future version of git, then I
>>> have no way of knowing how wide it is and cannot take measures to
>>> format my hook output so that it will look right.
>> Don't localize "remote:"?  Or pick a shorter translation?
>>
>> If its really a problem, maybe "remote: " prefix should turn into
>> something shorter and language agnostic, like "<< ".  But thus far
>> we hadn't had to worry about it, since we didn't have translation
>> support in Git...  (though yes, I see that is changing now).
> 
> Is there any reason for why the "remote:" output needs to be echoed
> verbatim to the user instead of being passed through some filter.
> 
> If not, then it could be treated as part of a protocol, parsed, and
> localized however the user wants.
> 
> ">" isn't as language-agnostic as you might think, in a RTL language
> the arrow ends up facing the wrong way.

Also seconded.

  reply	other threads:[~2010-06-11 21:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 20:32 Git sideband hook output Scott Chacon
2010-06-08 21:46 ` Shawn O. Pearce
2010-06-09  8:04   ` Peter Kjellerstedt
2010-06-09 13:44     ` Nicolas Pitre
2010-06-10 12:56       ` Peter Kjellerstedt
2010-06-10 18:05         ` Nicolas Pitre
2010-06-10 18:30         ` Shawn O. Pearce
2010-06-10 18:49           ` Scott Chacon
2010-06-11 14:34             ` PJ Hyett
2010-06-11 14:45               ` Wincent Colaiuta
2010-06-11 15:11                 ` Erik Faye-Lund
2010-06-11 23:52                   ` Junio C Hamano
2010-06-12  4:07                     ` Jeff King
2010-06-11 21:54                 ` A Large Angry SCM
2010-06-11 15:18           ` Ævar Arnfjörð Bjarmason
2010-06-11 21:55             ` A Large Angry SCM [this message]
2010-06-09  6:10 ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C12B0D0.9000805@gmail.com \
    --to=gitzilla@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=peter.kjellerstedt@axis.com \
    --cc=schacon@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).