git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>]
Date: Sat, 12 Jun 2010 13:38:54 +0200	[thread overview]
Message-ID: <4C1371CE.8010309@gnu.org> (raw)
In-Reply-To: <20100605005116.GA8774@progeny.tock>

On 06/05/2010 02:51 AM, Jonathan Nieder wrote:
> This series teaches ‘git grep’ to accept
>
> 	git grep -Ovi some_function_name
>
> to find all the call sites for some_function_name so they can be
> adjusted.  Dscho’s cover letter[1] explains it better.
>
> And in fact, Dscho did all the work here; this iteration just rebases it
> on master and adds some tests.
>
> Happy hacking,
> Jonathan
>
> Johannes Schindelin (2):
>    grep: Add the option '--open-files-in-pager'

Just a nit, why not just "--open-files-in"?  It is not necessarily a 
pager, as you cover letter shows.  Of course the shorter version works, 
but I'm asking because I would like to add this option to GNU grep and I 
would definitely prefer to avoid the "pager" reference.

Paolo

  parent reply	other threads:[~2010-06-12 11:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05  0:51 [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Jonathan Nieder
2010-06-05  0:53 ` [PATCH 1/2] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-05  1:40   ` Jonathan Nieder
2010-06-05  0:55 ` [PATCH 2/2] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-05 16:11 ` [PATCH v2 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12  7:55   ` Jonathan Nieder
2010-06-12  9:46     ` Johannes Schindelin
2010-06-12 16:29       ` [PATCH v3 0/4] " Jonathan Nieder
2010-06-12 16:31         ` [PATCH 1/4] grep: refactor grep_objects loop into its own function Jonathan Nieder
2010-06-12 16:32         ` [PATCH 2/4] Unify code paths of threaded greps Jonathan Nieder
2010-06-12 16:36         ` [PATCH 3/4] grep: Add the option '--open-files-in-pager' Jonathan Nieder
2010-06-12 16:39         ` [PATCH 4/4] grep -O: allow optional argument specifying the pager (or editor) Jonathan Nieder
2010-06-12 17:16           ` Paolo Bonzini
2010-06-13 16:35           ` Junio C Hamano
2010-06-13 17:04             ` Paolo Bonzini
2010-06-14  6:31             ` Jonathan Nieder
2010-06-12 21:36         ` [PATCH v3 0/4] Teach 'git grep' about --open-files-in-pager=[<pager>] Johannes Schindelin
2010-06-12 22:12           ` Jonathan Nieder
2010-06-12 11:38 ` Paolo Bonzini [this message]
2010-06-12 14:50   ` [PATCH v2 0/2] " Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1371CE.8010309@gnu.org \
    --to=bonzini@gnu.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).