From: Mark Levedahl <mlevedahl@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, jsixt@viscovery.net, spearce@spearce.org
Subject: Re: [PATCH 2/2 v2] git-gui - provide commit base to the hooks/pre-commit script
Date: Mon, 21 Jun 2010 21:07:57 -0400 [thread overview]
Message-ID: <4C200CED.7090402@gmail.com> (raw)
In-Reply-To: <20100621050012.GA13043@coredump.intra.peff.net>
On 06/21/2010 01:00 AM, Jeff King wrote:
> On Sun, Jun 20, 2010 at 09:54:39PM -0700, Junio C Hamano wrote:
>
>
>> I generally take absense of responses as absense of interest and/or
>> support, not absense of objection.
>>
>> For this particular patch, I am mostly indifferent (i.e. no objection, but
>> no strong support neither).
>>
> Ditto. I don't personally have a use, but all of my concerns were
> answered.
>
> -Peff
>
Well, I have a use else I wouldn't have written this :^).
Absent this patch, the default commit hook is always computing a diff
against HEAD and that is wrong when amending a commit. Folks may not
care, but that is an error so this patch fixes an existing bug. I'll
leave it at that.
Mark
prev parent reply other threads:[~2010-06-22 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 2:56 [PATCH 1/2 v2] commit.c - provide base commit to the hooks/pre-commit script Mark Levedahl
2010-06-08 2:56 ` [PATCH 2/2 v2] git-gui - provide commit base " Mark Levedahl
2010-06-19 2:59 ` Mark Levedahl
2010-06-21 4:54 ` Junio C Hamano
2010-06-21 5:00 ` Jeff King
2010-06-22 1:07 ` Mark Levedahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C200CED.7090402@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jsixt@viscovery.net \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).