From: Pascal Obry <pascal.obry@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v3] Do not decode url protocol.
Date: Tue, 22 Jun 2010 18:47:39 +0200 [thread overview]
Message-ID: <4C20E92B.1030405@obry.net> (raw)
In-Reply-To: <vpq39wf82y3.fsf@bauges.imag.fr>
Matthieu,
> Unless I missed something, this version doesn't address my earlier
> comment:
Because I do not agree. The three procedures:
char *url_decode(const char *url)
char *url_decode_parameter_name(const char **query)
char *url_decode_parameter_value(const char **query)
are all passed a full url (with protocol). We do not want to decode the
protocol in all three cases. The difference is only that the later two
are stopping the decoding at a given point in the url.
So to me, until I'm proved to be wrong, I think that v3 of my path is
correct.
Pascal.
--
--|------------------------------------------------------
--| Pascal Obry Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--| http://www.obry.net - http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B
next prev parent reply other threads:[~2010-06-22 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 11:58 [PATCH v3] Do not decode url protocol Pascal Obry
2010-06-22 16:08 ` Matthieu Moy
2010-06-22 16:47 ` Pascal Obry [this message]
2010-06-22 17:08 ` Matthieu Moy
2010-06-22 17:22 ` Pascal Obry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C20E92B.1030405@obry.net \
--to=pascal.obry@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).