From: Michael J Gruber <git@drmicha.warpmail.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Clément Poulain" <clement.poulain@ensimag.imag.fr>,
"Diane Gasselin" <diane.gasselin@ensimag.imag.fr>,
"Axel Bonnet" <axel.bonnet@ensimag.imag.fr>
Subject: Re: [PATCH] git-cat-file.txt: Document --textconv
Date: Thu, 24 Jun 2010 14:56:15 +0200 [thread overview]
Message-ID: <4C2355EF.7030604@drmicha.warpmail.net> (raw)
In-Reply-To: <vpqmxukir3e.fsf@bauges.imag.fr>
Matthieu Moy venit, vidit, dixit 24.06.2010 13:53:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
>> ---
>> This formulation is based on my understanding that you can't cat-file
>> --textconv something in the index or worktree.
>
> Actually, you can't textconv from the worktree, but you can from the
> index, saying
>
> git cat-file --textconv :path/to/file
>
> (the :<path> syntax is not specific here, you can use it in other Git
> commands)
>
>> +--textconv::
>> + Show the content as transformed by a textconv filter. In this case,
>> + <object> has be of the form <treeish:path>, with treeish defaulting to
>> + HEAD.
>
> So the "defaulting to HEAD" is incorrect.
Oh no, this is bad! I'd say every git command defaults to HEAD when a
commitish/treeish is not specified!!
Wait a minute:
git show HEAD:path >a
git show :path >b
diff a b
Oh no! We've been having this all along. This is bad but probably
unchangeable.
> Also, I prefer
> <treeish>:<path> to <treeish:path>, to make it clear the : is actually
> a :.
I was going with the usage line, but you are right: <a>:<b> makes more
sense semantically and is clearer.
>
> What about this:
>
> --textconv::
> Show the content as transformed by a textconv filter. In this
> case, <object> has be of the form <treeish>:<path>, or :<path>
> to run the filter on the file <path> stored in the index.
>
I'll be more mathematically stubborn about "file", see v2;)
Michael
next prev parent reply other threads:[~2010-06-24 12:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 10:14 [PATCH] git-cat-file.txt: Document --textconv Michael J Gruber
2010-06-24 11:53 ` Matthieu Moy
2010-06-24 12:56 ` Michael J Gruber [this message]
2010-06-24 12:56 ` [PATCHv2] " Michael J Gruber
2010-06-24 13:54 ` Matthieu Moy
2010-06-24 20:10 ` Junio C Hamano
2010-06-24 13:02 ` [PATCH] git-rev-parse.txt: Document ":path" specifier Michael J Gruber
2010-06-24 20:47 ` Junio C Hamano
2010-06-25 14:32 ` [PATCHv2] " Michael J Gruber
2010-06-25 15:25 ` Matthieu Moy
2010-06-25 17:52 ` Junio C Hamano
2010-06-27 13:15 ` [PATCHv3] " Michael J Gruber
2010-06-27 19:29 ` Junio C Hamano
2010-06-27 19:41 ` Michael J Gruber
2010-06-28 6:22 ` Matthieu Moy
2010-06-28 8:18 ` [PATCH] git-rev-parse.txt: Add more examples for caret and colon Michael J Gruber
2010-06-28 10:03 ` Peter Kjellerstedt
2010-06-28 10:27 ` Michael J Gruber
2010-06-28 19:01 ` [PATCHv2] " Michael J Gruber
2010-06-25 15:53 ` [PATCHv2] git-rev-parse.txt: Document ":path" specifier Junio C Hamano
2010-06-24 20:09 ` [PATCH] git-cat-file.txt: Document --textconv Junio C Hamano
2010-06-25 9:04 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2355EF.7030604@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=axel.bonnet@ensimag.imag.fr \
--cc=clement.poulain@ensimag.imag.fr \
--cc=diane.gasselin@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).