From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH 1/4] msvc: Fix some "expr evaluates to function" compiler warnings
Date: Fri, 25 Jun 2010 20:48:26 +0100 [thread overview]
Message-ID: <4C25080A.107@ramsay1.demon.co.uk> (raw)
In-Reply-To: <201006241201.08212.johan@herland.net>
Johan Herland wrote:
> On Wednesday 23 June 2010, Ramsay Jones wrote:
>> In particular, the following warning is issued while compiling
>> notes.c:
>>
>> notes.c(927) : warning C4550: expression evaluates to a \
>> function which is missing an argument list
>>
>> along with identical warnings on lines 928, 1016 and 1017.
>>
>> In order to suppress the warning, we change the definition of
>> combine_notes_fn, so that the symbol type is an (explicit)
>> "pointer to function ...". As a result, several other
>> declarations need some minor fix-up to take account of the
>> new typedef.
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>
> Acked-by: Johan Herland <johan@herland.net>
Thanks!
ATB,
Ramsay Jones
next prev parent reply other threads:[~2010-06-26 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 19:40 [PATCH 1/4] msvc: Fix some "expr evaluates to function" compiler warnings Ramsay Jones
2010-06-24 10:01 ` Johan Herland
2010-06-25 19:48 ` Ramsay Jones [this message]
2010-06-29 16:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C25080A.107@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).