From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Nazri Ramliy <ayiehere@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org,
johannes.schindelin@gmx.de, jrnieder@gmail.com
Subject: Re: [PATCH] Bugfix: grep: Do not colorize output when -O is set
Date: Fri, 02 Jul 2010 18:19:17 +0200 [thread overview]
Message-ID: <4C2E1185.1040406@lsrfire.ath.cx> (raw)
In-Reply-To: <1278064941-30689-1-git-send-email-ayiehere@gmail.com>
Am 02.07.2010 12:02, schrieb Nazri Ramliy:
> When color.ui is set to auto, "git grep -Ovi foo" breaks due to the
> presence of color escape sequences.
Hmm, but with --open-files-in-pager without argument or -Oless colours
may be handled correctly and desirable. Turning colouring off with -O
is probably the most sensible default, but is it possible to allow
turning it back on explicitly (--color -O)?
René
next prev parent reply other threads:[~2010-07-02 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 10:02 [PATCH] Bugfix: grep: Do not colorize output when -O is set Nazri Ramliy
2010-07-02 16:19 ` René Scharfe [this message]
2010-07-06 19:38 ` Jonathan Nieder
2010-07-06 20:19 ` René Scharfe
2010-07-02 19:21 ` Jonathan Nieder
2010-07-03 1:20 ` Nazri Ramliy
2010-07-03 2:55 ` [PATCH v2] grep -O: Do not pass color sequences as filenames to pager Jonathan Nieder
2010-07-03 7:59 ` [PATCH] Bugfix: grep: Do not colorize output when -O is set Jakub Narebski
2010-07-06 20:04 ` [PATCH] t/README: document more test helpers Jonathan Nieder
2010-07-06 20:23 ` Ævar Arnfjörð Bjarmason
2010-07-07 4:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2E1185.1040406@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=ayiehere@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).