From: Michael J Gruber <git@drmicha.warpmail.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: gitster@pobox.com, git@vger.kernel.org, PWalker752@aol.com,
newsletter@dirk.my1.cc, bruce.stephens@isode.com,
Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH 2/2] Makefile: work around ksh's failure to handle missing list argument to for loop
Date: Sun, 04 Jul 2010 20:37:09 +0200 [thread overview]
Message-ID: <4C30D4D5.3020900@drmicha.warpmail.net> (raw)
In-Reply-To: <8YdP-GcDDflOVZnykNVIGceOm01bqeg9PDvdgIfgqUnh29RKC-6Qi8_KBVoqLIt5iyt7g1TX5l96M5KyLrfOqg@cipher.nrlssc.navy.mil>
Brandon Casey venit, vidit, dixit 02.07.2010 20:50:
> From: Brandon Casey <drafnel@gmail.com>
>
> ksh does not like it when the list argument is missing in a for loop. This
> can happen when NO_CURL is set which causes REMOTE_CURL_ALIASES to be unset.
> In this case, the for loop in the Makefile expands to look like this:
>
> for p in ; do
>
> and ksh complains like this:
>
> /bin/ksh: syntax error at line 15 : `;' unexpected
>
> The existing attempt to work around this issue, introduced by 70b89f87,
> tried to protect the for loop by first testing whether REMOTE_CURL_ALIASES
> was empty, but it does not seem to work. So adopt Bruce Stephens's
What does that mean? Either it works or it doesn't. I did work back
then. Does it (i.e.: the test for emtyness) fail to work for certain shells?
Michael
next prev parent reply other threads:[~2010-07-04 18:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 13:35 installation issue when building with NO_CURL=YesPlease Paul Walker
2010-05-26 13:58 ` Michael J Gruber
2010-05-26 14:41 ` Paul Walker
2010-05-26 13:58 ` Ramkumar Ramachandra
2010-05-26 14:15 ` Paul Walker
2010-05-26 14:24 ` [PATCH] Makefile: reenable install with NO_CURL Michael J Gruber
2010-05-26 18:27 ` installation issue when building with NO_CURL=YesPlease Dirk Süsserott
2010-05-26 18:45 ` Bruce Stephens
2010-05-26 19:03 ` Dirk Süsserott
2010-07-02 18:50 ` [PATCH 1/2] Makefile: remove some unnecessary curly braces Brandon Casey
2010-07-02 18:50 ` [PATCH 2/2] Makefile: work around ksh's failure to handle missing list argument to for loop Brandon Casey
2010-07-03 6:21 ` Raja R Harinath
2010-07-04 18:37 ` Michael J Gruber [this message]
2010-07-05 6:19 ` Johannes Sixt
2010-07-05 8:14 ` Michael J Gruber
2010-07-05 9:15 ` Johannes Sixt
2010-07-05 9:31 ` Michael J Gruber
2010-07-05 18:18 ` Junio C Hamano
2010-07-05 20:00 ` Andreas Schwab
2010-07-05 21:29 ` Brandon Casey
2010-07-06 2:36 ` Junio C Hamano
2010-07-06 21:56 ` [PATCH 2/2 v2] " Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C30D4D5.3020900@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=PWalker752@aol.com \
--cc=bruce.stephens@isode.com \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newsletter@dirk.my1.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).