From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Eric Wong <normalperson@yhbt.net>,
Torsten Schmutzler <git-ts@theblacksun.eu>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-svn: mangle refnames forbidden in git
Date: Thu, 08 Jul 2010 20:53:41 +0200 [thread overview]
Message-ID: <4C361EB5.7010704@drmicha.warpmail.net> (raw)
In-Reply-To: <20100708130315.GA1529@burratino>
Jonathan Nieder venit, vidit, dixit 08.07.2010 15:03:
> Eric Wong wrote:
>
>> I can't reproduce it with 1.5.1 here, does URI-escaping the "@{0}"
>> to "%40%7B0%7D" work?
>
> Yes.
>
> ...
> $ svn cp -m reflog file:///tmp/foo/source 'file:///tmp/foo/not-a%40%7B0%7Dreflog'
> Committed revision 2.
> $ (cd wc && svn update)
> A not-a@{0}reflog
> Updated to revision 2.
>
> Does that work with svn 1.5.x?
It turns out this is not so much about general escaping but about the
treatment of so called svn PEG revisions (not so unsimilar to our @{}).
svn r954995 integrated r952973 (which implemented the eating of PEG
revisions) into the 1.6.x branch. It's considered a bug fix.
This "fix" is in 1.6.12 but not in 1.6.11.
Now, git-svn adjusts its behaviour to the svn version for things like
info. But I don't know if it's worth doing in this case - maybe we
should just change the test not to use the PEG revisions identifier "@".
Michael
next prev parent reply other threads:[~2010-07-08 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 20:20 [PATCH] git-svn: mangle refnames forbidden in git Torsten Schmutzler
2010-05-09 8:35 ` Eric Wong
2010-07-08 8:43 ` Jonathan Nieder
2010-07-08 8:58 ` Eric Wong
2010-07-08 13:03 ` Jonathan Nieder
2010-07-08 18:53 ` Michael J Gruber [this message]
2010-07-08 19:16 ` [PATCH] t9118: avoid PEG revision identifier in tests Michael J Gruber
2010-07-08 19:33 ` A Large Angry SCM
2010-07-08 20:38 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C361EB5.7010704@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git-ts@theblacksun.eu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).