From: Michael J Gruber <git@drmicha.warpmail.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] tests: Use skip_all=* to skip tests
Date: Fri, 09 Jul 2010 11:33:15 +0200 [thread overview]
Message-ID: <4C36ECDB.9090707@drmicha.warpmail.net> (raw)
In-Reply-To: <1278551766-27569-1-git-send-email-avarab@gmail.com>
After trying out tests with prove (I like it!) I was just about to make
a patch before I saw this...
So, this does what it should, at least with my set of prerequisites.
Ævar Arnfjörð Bjarmason venit, vidit, dixit 08.07.2010 03:16:
> Change tests to skip with skip_all=* + test_done instead of using say
> + test_done.
I didn't understand this at all at first, only after I was about to
write that patch myself. Maybe 'with skip_all="reason"' or
'skip_all=<reason>' etc.?
>
> This is a follow-up to "tests: Skip tests in a way that makes sense
> under TAP" (fadb5156e4). I missed these cases when prepearing that
"preparing", although that last sentence sounds more like "after ---
material".
> patch, hopefully this is all of them.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
No comments to the patch itself, it works :)
Michael
next prev parent reply other threads:[~2010-07-09 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 1:16 [PATCH] tests: Use skip_all=* to skip tests Ævar Arnfjörð Bjarmason
2010-07-09 9:33 ` Michael J Gruber [this message]
2010-07-09 11:41 ` [PATCH v2] tests: Use skip_all=<reason> " Ævar Arnfjörð Bjarmason
2010-07-09 17:49 ` Junio C Hamano
2010-07-09 19:14 ` Ævar Arnfjörð Bjarmason
2010-07-09 22:47 ` Junio C Hamano
2010-07-09 23:28 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C36ECDB.9090707@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).