git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "C. Michael Pilato" <cmpilato@collab.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
	"dev@subversion.apache.org" <dev@subversion.apache.org>,
	Bert Huijben <rhuijben@collab.net>,
	Daniel Shahaf <d.s@daniel.shahaf.name>,
	Will Palmer <wmpalmer@gmail.com>,
	David Michael Barr <david.barr@cordelta.com>,
	Sverre Rabbelier <srabbelier@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] Add svnrdump
Date: Wed, 14 Jul 2010 13:56:14 -0400	[thread overview]
Message-ID: <4C3DFA3E.7000809@collab.net> (raw)
In-Reply-To: <20100714174716.GB2866@burratino>

On 07/14/2010 01:47 PM, Jonathan Nieder wrote:
> C. Michael Pilato wrote:
> 
>> Revprops aren't handled by the replay API for any revision.
> 
> Hmm?  What is the rev_props argument to the
> 
> typedef svn_error_t (*svn_ra_replay_revstart_callback_t)(
> 				svn_revnum_t revision,
> 				void *replay_baton,
> 				const svn_delta_editor_t **editor,
> 				void **edit_baton,
> 				apr_hash_t *rev_props,
> 				apr_pool_t *pool)
> 
> callback for, then?
> 
> Using svn_ra_rev_prop() for rev 0 does seem simple enough, though.

Ah, I was talking about the svn_repos_replay() API (which is used by the
svn_ra_replay() API).  It definitely makes sense to me that the RA's replay
API be able to report the revprops for revision 0.

Sorry for the confusion.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

  reply	other threads:[~2010-07-14 17:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09 14:29 [PATCH v2] Add svnrdump Ramkumar Ramachandra
2010-07-13 20:11 ` Stefan Sperling
2010-07-14 15:32   ` Stefan Sperling
2010-07-14 16:01     ` Ramkumar Ramachandra
2010-07-14 16:48       ` C. Michael Pilato
2010-07-15 10:28         ` Ramkumar Ramachandra
2010-07-14 17:24       ` Stefan Sperling
2010-07-14 17:31         ` C. Michael Pilato
2010-07-14 17:34           ` Stefan Sperling
2010-07-14 17:47           ` Jonathan Nieder
2010-07-14 17:56             ` C. Michael Pilato [this message]
2010-07-15 12:01         ` Ramkumar Ramachandra
2010-07-14 19:25       ` Bert Huijben
2010-07-15 12:07         ` Ramkumar Ramachandra
2010-07-15 19:02   ` Ramkumar Ramachandra
2010-07-15 19:23     ` Stefan Sperling
2010-07-21 11:46       ` Ramkumar Ramachandra
2010-07-21 13:29         ` Daniel Shahaf
2010-07-21 19:03   ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3DFA3E.7000809@collab.net \
    --to=cmpilato@collab.net \
    --cc=artagnon@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=david.barr@cordelta.com \
    --cc=dev@subversion.apache.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=rhuijben@collab.net \
    --cc=srabbelier@gmail.com \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).