From: Jens Lehmann <Jens.Lehmann@web.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git submodule add: Remove old docs about implicit -f
Date: Sat, 17 Jul 2010 18:26:15 +0200 [thread overview]
Message-ID: <4C41D9A7.7000508@web.de> (raw)
In-Reply-To: <1279382025-24814-1-git-send-email-avarab@gmail.com>
Am 17.07.2010 17:53, schrieb Ævar Arnfjörð Bjarmason:
> git submodule add no longer implicitly adds with --force. Remove
> references to the old functionality in the documentation.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> This amended patch removes some obsolete documentation that you
> missed.
Yeah, thanks!
Acked-by: Jens Lehmann <Jens.Lehmann@web.de>
>> + echo >&2 "The following path is ignored by one of your .gitignore files:" &&
>> + echo >&2 $path &&
>> + echo >&2 "Use -f if you really want to add it."
>
> Is the "it" intentional? We currently say "them" in git add regardless
> of how many things are being added, so perhaps we should say "it"
> there too for singulars.
Yes, the "it" is intentional. While "git add" may be called with one
or more files, "git submodule add" can only be called with one path.
That's why I chose the singular form here.
prev parent reply other threads:[~2010-07-17 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 19:22 [PATCH/RFC] git submodule: add submodules with git add -f <path> Ævar Arnfjörð Bjarmason
2010-07-05 17:33 ` [PATCH] " Ævar Arnfjörð Bjarmason
2010-07-06 2:36 ` Junio C Hamano
2010-07-06 21:51 ` Jens Lehmann
2010-07-06 22:33 ` Ævar Arnfjörð Bjarmason
2010-07-09 22:18 ` [PATCH] git add: Add the "--ignore-missing" option for the dry run Jens Lehmann
2010-07-12 22:14 ` Junio C Hamano
2010-07-17 15:11 ` [PATCH] git submodule add: Require the new --force option to add ignored paths Jens Lehmann
2010-07-17 15:53 ` [PATCH] git submodule add: Remove old docs about implicit -f Ævar Arnfjörð Bjarmason
2010-07-17 16:26 ` Jens Lehmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C41D9A7.7000508@web.de \
--to=jens.lehmann@web.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).