git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "\"Alejandro R. Sedeño\"" <asedeno@MIT.EDU>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: move highlight config out of guess_file_syntax()
Date: Sun, 25 Jul 2010 19:53:04 -0400	[thread overview]
Message-ID: <4C4CCE60.1080301@mit.edu> (raw)
In-Reply-To: <201007260135.35059.jnareb@gmail.com>

On 7/25/2010 7:35 PM, Jakub Narebski wrote:
> BTW. is this something _you_ needed (and what did you need to configure
> / to put in $GITWEB_CONFIG file), or just a generalization?


This is something I was using in previous versions of gitweb, though
with the older (pre-592ea41) syntax. (I had applied the older
highlighting patches, and was quite happy to see them merged.)

Before, $GITWEB_CONFIG contained lines like:

  $highlight_type{'\.lisp$'} = 'lisp';

As of 1.7.2, with syntax highlighting merged and refactored (592ea41),
access to the hashes that define syntax highlighting mappings was lost.
Moving the hashes out into the config area lets $GITWEB_CONFIG contain
lines like:

  $highlight_ext{'lisp'} = 'lisp';
  $highlight_basename{'GNUmakefile'} = 'mak'

  parent reply	other threads:[~2010-07-25 23:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 19:46 [PATCH] gitweb: move highlight config out of guess_file_syntax() Alejandro R. Sedeño
     [not found] ` <201007260135.35059.jnareb@gmail.com>
2010-07-25 23:53   ` "Alejandro R. Sedeño" [this message]
2010-07-26 20:48     ` Jakub Narebski
2010-07-26 20:56       ` "Alejandro R. Sedeño"
2010-07-26 20:45   ` Jakub Narebski
2010-07-28 18:40     ` Alejandro R. Sedeño

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4CCE60.1080301@mit.edu \
    --to=asedeno@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).