From: Andrew Sayers <andrew-git@pileofstuff.org>
To: Git Mailing List <git@vger.kernel.org>
Cc: solsTiCe d'Hiver <solstice.dhiver@gmail.com>
Subject: [PATCH] bash-completion: Print a useful error when called in a non-bash shell
Date: Wed, 28 Jul 2010 23:32:37 +0100 [thread overview]
Message-ID: <4C50B005.1030004@pileofstuff.org> (raw)
Detect whether the shell supports process substitution with <()
Shells that fail the test will not be able to load git-completion.bash
If a bad shell is found, print a warning which gives the user as much debugging
information as possible.
This was added in response to a bug report on the git mailing list:
http://permalink.gmane.org/gmane.comp.version-control.git/151723
Signed-off-by: Andrew Sayers <andrew-git@pileofstuff.org>
---
My thanks to solsTiCe d'Hiver for reporting this bug.
contrib/completion/git-completion.bash | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 6756990..3bbb4da 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -96,6 +96,31 @@ __gitdir ()
fi
}
+# Check in case we were called with something like "sh git-completion.bash":
+$(
+ exec 2>/dev/null
+ $(exec < <( ))
+ )
+if [[ 0 -ne $? ]]
+then
+ cat <<EOF
+
+ERROR: you don't seem to be running a full bash shell.
+git-completion.bash is probably about to fail with a syntax error.
+If you are sure that your system is calling git-completion.bash from a bash,
+then please include the following in a bug report to git@vger.kernel.org:
+
+ BASH_VERSION: {$BASH_VERSION}
+ BASHOPTS: {$BASHOPTS}
+ SHELLOPTS: {$SHELLOPTS}
+ POSIXLY_CORRECT: {$POSIXLY_CORRECT}
+EOF
+ echo -n " command line: {"
+ tr '\0' ' ' < /proc/$$/cmdline
+ echo "}"
+ echo
+fi
+
# stores the divergence from upstream in $p
# used by GIT_PS1_SHOWUPSTREAM
__git_ps1_show_upstream ()
--
1.7.0.4
next reply other threads:[~2010-07-28 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 22:32 Andrew Sayers [this message]
2010-07-29 16:25 ` [PATCH] bash-completion: Print a useful error when called in a non-bash shell Junio C Hamano
2010-07-29 19:05 ` solsTiCe d'Hiver
2010-07-29 21:29 ` Andrew Sayers
2010-07-29 22:16 ` Ævar Arnfjörð Bjarmason
2010-07-29 23:38 ` Junio C Hamano
2010-07-30 6:02 ` Stephen Boyd
2010-08-06 21:31 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C50B005.1030004@pileofstuff.org \
--to=andrew-git@pileofstuff.org \
--cc=git@vger.kernel.org \
--cc=solstice.dhiver@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).