From: Tomas Carnecky <tom@dbservice.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Adam Mercer <ramercer@gmail.com>
Subject: Re: [PATCH] filter-branch tests/docs: avoid \t in sed regexes
Date: Thu, 29 Jul 2010 16:47:52 +0200 [thread overview]
Message-ID: <4C519498.3000702@dbservice.com> (raw)
In-Reply-To: <0bb511ca2d155ea7e37850a78375da1803032d6c.1280409717.git.trast@student.ethz.ch>
On 7/29/10 3:24 PM, Thomas Rast wrote:
> Using \t to represent a tab character is not portable beyond GNU sed
> (see e.g. GNU sed's info pages). Use printf to generate the tab
> instead.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> Adam Mercer wrote:
>>> What OS is this?
>> This was on Mac OS X 10.6. Where sed is BSD sed.
>
> That's very funny however, since it means that nobody should ever have
> had a successful test run on OS X with the preinstalled tools. What
> gives?
v1.7.2-rc1 on 10.6:
fixed 3
success 6328
failed 0
broken 21
total 6355
*** t7003-filter-branch.sh ***
* ok 1: setup
* ok 2: rewrite identically
* ok 3: result is really identical
* ok 4: rewrite bare repository identically
* ok 5: result is really identical
* ok 6: correct GIT_DIR while using -d
* ok 7: Fail if commit filter fails
* ok 8: rewrite, renaming a specific file
* ok 9: test that the file was renamed
* ok 10: rewrite, renaming a specific directory
* ok 11: test that the directory was renamed
* ok 12: rewrite one branch, keeping a side branch
* ok 13: common ancestor is still common (unchanged)
* ok 14: filter subdirectory only
* ok 15: subdirectory filter result looks okay
* ok 16: more setup
* ok 17: use index-filter to move into a subdirectory
* ok 18: stops when msg filter fails
* ok 19: author information is preserved
* ok 20: remove a certain author's commits
* ok 21: barf on invalid name
* ok 22: "map" works in commit filter
* ok 23: Name needing quotes
* ok 24: Subdirectory filter with disappearing trees
* ok 25: Tag name filtering retains tag message
* ok 26: Tag name filtering strips gpg signature
* ok 27: Tag name filtering allows slashes in tag names
* ok 28: Prune empty commits
* ok 29: --remap-to-ancestor with filename filters
* ok 30: setup submodule
* ok 31: rewrite submodule with another content
* ok 32: replace submodule revision
next prev parent reply other threads:[~2010-07-29 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 12:37 Using filter-branch to move repo contents in subdirectory Adam Mercer
2010-07-29 13:08 ` Thomas Rast
2010-07-29 13:15 ` Adam Mercer
2010-07-29 13:24 ` [PATCH] filter-branch tests/docs: avoid \t in sed regexes Thomas Rast
2010-07-29 14:47 ` Tomas Carnecky [this message]
2010-07-29 14:52 ` Thomas Rast
2010-07-29 15:02 ` Tomas Carnecky
2010-07-29 15:10 ` [PATCH] t7005: fix subdirectory-filter test Thomas Rast
2010-07-29 15:12 ` Thomas Rast
2010-08-09 19:36 ` Using filter-branch to move repo contents in subdirectory Adam Mercer
2010-08-11 15:01 ` Adam Mercer
2010-08-11 19:32 ` Jeff King
2010-08-11 19:59 ` Adam Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C519498.3000702@dbservice.com \
--to=tom@dbservice.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramercer@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).