From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 0/2] Submodules: Add the new config option "ignore"
Date: Fri, 06 Aug 2010 01:51:28 +0200 [thread overview]
Message-ID: <4C5B4E80.1070102@web.de> (raw)
In-Reply-To: <7vvd7obpy5.fsf@alter.siamese.dyndns.org>
Am 06.08.2010 01:27, schrieb Junio C Hamano:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>> Am 28.07.2010 23:35, schrieb Junio C Hamano:
>>> The value of "submodule.<name>.path" does not have to be "<name>". There
>>> seems to be a bit of confusion here.
>>
>> Thanks for clearing up my confusion, this is v2 of this patch using the
>> path configured for the submodule instead of its name.
>
> Hmph, I thought that it would make more sense to use <name> so that once
> the user configures ignore in .git/config, it will persist across moving
> of the submodule in the superproject tree. I wonder what others would
> think.
I think that is just what this patch does, it uses the
"config_name_for_path" string_list to get the submodules <name> for the
path to then look up what is configured for the "ignore" option under
that <name>. So the "ignore" option should survive renames, no? Or did
I manage to confuse myself again?
next prev parent reply other threads:[~2010-08-05 23:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 18:26 [PATCH 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-07-26 18:27 ` [PATCH 1/2] Submodules: Add the new "ignore" config option for diff and status Jens Lehmann
2010-07-26 18:28 ` [PATCH 2/2] Submodules: Use "ignore" settings from .gitmodules too " Jens Lehmann
2010-07-28 21:35 ` Junio C Hamano
2010-08-05 22:37 ` [PATCH v2 0/2] Submodules: Add the new config option "ignore" Jens Lehmann
2010-08-05 22:39 ` [PATCH v2 1/2] Submodules: Add the new "ignore" config option for diff and status Jens Lehmann
2010-08-05 22:40 ` [PATCH v2 2/2] Submodules: Use "ignore" settings from .gitmodules too " Jens Lehmann
2010-08-05 23:27 ` [PATCH v2 0/2] Submodules: Add the new config option "ignore" Junio C Hamano
2010-08-05 23:51 ` Jens Lehmann [this message]
2010-08-09 16:57 ` Junio C Hamano
2010-08-05 9:21 ` [PATCH " Johannes Schindelin
2010-08-05 16:49 ` Junio C Hamano
2010-08-05 19:08 ` Jens Lehmann
2010-08-05 23:27 ` [PATCH] Add tests for the diff.ignoreSubmodules config option Jens Lehmann
2010-08-09 16:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5B4E80.1070102@web.de \
--to=jens.lehmann@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).