From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] prune: allow --dry-run for -n and --verbose for -v
Date: Fri, 06 Aug 2010 23:41:39 +0200 [thread overview]
Message-ID: <4C5C8193.1040608@lsrfire.ath.cx> (raw)
In-Reply-To: <20100806210429.GA6495@burratino>
Am 06.08.2010 23:04, schrieb Jonathan Nieder:
> René Scharfe wrote:
>
>> +++ b/builtin/prune.c
>> @@ -125,10 +125,9 @@ int cmd_prune(int argc, const char **argv, const char *prefix)
>> {
>> struct rev_info revs;
>> const struct option options[] = {
>> - OPT_BOOLEAN('n', NULL, &show_only,
>> + OPT_BOOLEAN('n', "dry-run", &show_only,
>
> For the curious: avoiding OPT__DRY_RUN allows us to give a better
> description:
>
>> "do not remove, show only"),
>
> which makes sense to me. Thanks.
Indeed.
Adding a helptext parameter to OPT__DRY_RUN à la OPT__COLOR would make
it usable here as well as in commit.c and fetch.c. Similar changes
could help OPT__VERBOSE and OPT__QUIET. Their standard helptexts don't
add a lot of information..
René
next prev parent reply other threads:[~2010-08-06 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 20:28 [PATCH] prune: allow --dry-run for -n and --verbose for -v René Scharfe
2010-08-06 21:04 ` Jonathan Nieder
2010-08-06 21:41 ` René Scharfe [this message]
2010-08-07 8:25 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5C8193.1040608@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).