From: Stephen Boyd <bebarino@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
git@vger.kernel.org, kernel@pengutronix.de
Subject: Re: gitweb not friendly to firefox revived
Date: Sat, 14 Aug 2010 03:33:18 -0700 [thread overview]
Message-ID: <4C6670EE.3060806@gmail.com> (raw)
In-Reply-To: <201008032350.40117.jnareb@gmail.com>
On 08/03/2010 02:50 PM, Jakub Narebski wrote:
> +
> + my $title = to_utf8("Search for commits $performed by $author");
> + $title =~ s/[[:cntrl:]]/?/g;
> +
>
Isn't it possible that other data coming from git could have escape characters in them such as the commit subject line? In which case this same bug would occur?
Therefore isn't it better to strip out control characters (that's what this patch is doing right?) in esc_html?
next prev parent reply other threads:[~2010-08-14 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 19:51 gitweb not friendly to firefox revived Uwe Kleine-König
2010-08-01 20:15 ` Ævar Arnfjörð Bjarmason
2010-08-02 5:31 ` Uwe Kleine-König
2010-08-01 20:26 ` Jakub Narebski
2010-08-03 21:07 ` Uwe Kleine-König
2010-08-03 21:50 ` Jakub Narebski
2010-08-12 9:23 ` Uwe Kleine-König
2010-08-14 10:33 ` Stephen Boyd [this message]
2010-08-14 10:48 ` Ævar Arnfjörð Bjarmason
2010-08-14 12:33 ` Jakub Narebski
2010-09-07 8:22 ` Uwe Kleine-König
2010-08-14 12:29 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6670EE.3060806@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=kernel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).