git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: [PATCH 0/2] checkout: diff.ignoreSubmodules: Add test and honor per submodule settings too
Date: Sat, 28 Aug 2010 16:48:29 +0200	[thread overview]
Message-ID: <4C7921BD.7030600@web.de> (raw)
In-Reply-To: <4C7591D7.9050508@web.de>

Am 25.08.2010 23:57, schrieb Jens Lehmann:
> Am 25.08.2010 22:10, schrieb Junio C Hamano:
>> Thanks.  Perhaps we would want a new test or two in t2013?
> 
> Sure, I will add some as soon as I find some time ...

Ok, here we go!

While writing the test I noticed it might be nice to use the
configuration settings consistently. So I did a second patch
teaching checkout to honor the submodule.*.ignore settings
the same way diff and status do.

Two other issues surfaced while working on these patches:

1) We might have to teach the --ignore-submodules option to
   checkout too to be able to override the configuration on
   the command line and in scripts.

2) It might be a good idea to let "git status" honor the
   diff.ignoreSubmodules setting too, so that the output is
   consistent with that of diff and checkout.

Opinions?

(While I am willing to write the patches, I am not a user of
these config options myself, so feedback from people who do
use them is very much appreciated!)


Jens Lehmann (2):
  checkout: Add test for diff.ignoreSubmodules
  checkout: Use submodule.*.ignore settings from .git/config and
    .gitmodules

 Documentation/config.txt      |    3 ++-
 builtin/checkout.c            |    5 +++++
 t/t2013-checkout-submodule.sh |   23 +++++++++++++++++++++++
 3 files changed, 30 insertions(+), 1 deletions(-)

-- 
1.7.2.2.515.g13860

  reply	other threads:[~2010-08-28 14:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 10:34 [PATCH] checkout: respect diff.ignoreSubmodules setting Johannes Schindelin
2010-08-25 17:48 ` Jens Lehmann
2010-08-25 20:10   ` Junio C Hamano
2010-08-25 21:57     ` Jens Lehmann
2010-08-28 14:48       ` Jens Lehmann [this message]
2010-08-28 14:49         ` [PATCH 1/2] checkout: Add test for diff.ignoreSubmodules Jens Lehmann
2010-08-28 14:50         ` [PATCH 2/2] checkout: Use submodule.*.ignore settings from .git/config and .gitmodules Jens Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7921BD.7030600@web.de \
    --to=jens.lehmann@web.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).