From: Stephen Boyd <bebarino@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: Why isn't builtin.h used by all builtin/*.c files?
Date: Wed, 01 Sep 2010 07:56:37 -0700 [thread overview]
Message-ID: <4C7E69A5.4070008@gmail.com> (raw)
In-Reply-To: <AANLkTinHtvHt0q=dK9KHtCX6JzymB5dx1NuaAZN_uu2R@mail.gmail.com>
On 09/01/2010 07:17 AM, Ævar Arnfjörð Bjarmason wrote:
> I'm working on gettextizing the 'mainporcelain common' commands now,
> and I ran into this:
>
[snip]
>
> Anyway, I'll convert these to builtin.h where appropriate as part of
> the series unless someone can find a good reason not to.
Sparse warns about this too. "Prototype not found, should it be static?"
for a few cmd_*'s. So sounds good to me.
next prev parent reply other threads:[~2010-09-01 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 14:17 Why isn't builtin.h used by all builtin/*.c files? Ævar Arnfjörð Bjarmason
2010-09-01 14:56 ` Stephen Boyd [this message]
2010-09-01 17:31 ` Junio C Hamano
2010-09-01 16:23 ` [PATCH] builtin: use builtin.h for all builtin/ commands Ævar Arnfjörð Bjarmason
2010-09-01 17:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7E69A5.4070008@gmail.com \
--to=bebarino@gmail.com \
--cc=avarab@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).