* git send-email doesn't take To: addresses from the patch
@ 2010-08-30 7:05 viresh kumar
2010-09-01 7:50 ` Stephen Boyd
0 siblings, 1 reply; 6+ messages in thread
From: viresh kumar @ 2010-08-30 7:05 UTC (permalink / raw)
To: git
Hi,
I am using git-1.7.2 and use following command to generate a patch
$ git format-patch --to abc@xyz.com HEAD^
Now when I use git send-email to send this patch, it is not taking the
To: embedded in the patch as its destination, instead it asks for one
and if not provided it keeps this field empty.
On the other hand git send-email is taking the Cc addresses from
the patch perfectly in to account.
How can I use git send-email to pick To: addresses directly from the
patch.
regards
Viresh Kumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git send-email doesn't take To: addresses from the patch
2010-08-30 7:05 git send-email doesn't take To: addresses from the patch viresh kumar
@ 2010-09-01 7:50 ` Stephen Boyd
2010-09-01 8:56 ` viresh kumar
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Boyd @ 2010-09-01 7:50 UTC (permalink / raw)
To: viresh kumar; +Cc: git
On 08/30/2010 12:05 AM, viresh kumar wrote:
> Hi,
>
> I am using git-1.7.2 and use following command to generate a patch
>
> $ git format-patch --to abc@xyz.com HEAD^
>
> Now when I use git send-email to send this patch, it is not taking the
> To: embedded in the patch as its destination, instead it asks for one
> and if not provided it keeps this field empty.
> On the other hand git send-email is taking the Cc addresses from
> the patch perfectly in to account.
>
> How can I use git send-email to pick To: addresses directly from the
> patch.
You can't. Nobody has bothered to make git-send-email consider the To: field. Can you try this patch out? I think it will mostly work, except I haven't bothered to look at --compose yet and I'm halfway stumbling through this code right now.
---->8-----
Subject: [PATCH] send-email: Use To: headers in patch files
It's a minor annoyance when you take the painstaking time to setup To:
headers for each patch in a large series, and then go out to send the
series with git-send-email and watch git ignore the To: headers in the
patch files.
Therefore, always add To: headers from a patch file to the To: headers
for that message. Keep the prompt for the blanket To: header so as to
not break scripts (and user expectations). This means even if a patch has a
To: header, git will prompt for the To: address. Otherwise, we'll need to
introduce interface breakage to either request the header for each patch
missing a To: header or default the header to whatever To: address is found
first (be it in a patch or from user input). Both of these options don't seem
very obvious/useful.
Reported-by: viresh kumar<viresh.kumar@st.com>
Signed-off-by: Stephen Boyd<bebarino@gmail.com>
---
git-send-email.perl | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 6dab3bf..06373ed 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1176,6 +1176,13 @@ foreach my $t (@files) {
$1, $_) unless $quiet;
push @cc, $1;
}
+ elsif (/^To:\s+(.*)$/) {
+ foreach my $addr (parse_address_line($1)) {
+ printf("(mbox) Adding to: %s from line '%s'\n",
+ $addr, $_) unless $quiet;
+ push @to, sanitize_address($addr);
+ }
+ }
elsif (/^Cc:\s+(.*)$/) {
foreach my $addr (parse_address_line($1)) {
if (unquote_rfc2047($addr) eq $sender) {
--
1.7.2.2.178.gd8a94
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: git send-email doesn't take To: addresses from the patch
2010-09-01 7:50 ` Stephen Boyd
@ 2010-09-01 8:56 ` viresh kumar
2010-09-02 18:36 ` Stephen Boyd
0 siblings, 1 reply; 6+ messages in thread
From: viresh kumar @ 2010-09-01 8:56 UTC (permalink / raw)
To: Stephen Boyd; +Cc: git@vger.kernel.org
On 9/1/2010 1:20 PM, Stephen Boyd wrote:
> Subject: [PATCH] send-email: Use To: headers in patch files
>
> It's a minor annoyance when you take the painstaking time to setup To:
> headers for each patch in a large series, and then go out to send the
> series with git-send-email and watch git ignore the To: headers in the
> patch files.
>
> Therefore, always add To: headers from a patch file to the To: headers
> for that message. Keep the prompt for the blanket To: header so as to
> not break scripts (and user expectations). This means even if a patch has a
> To: header, git will prompt for the To: address. Otherwise, we'll need to
> introduce interface breakage to either request the header for each patch
> missing a To: header or default the header to whatever To: address is found
> first (be it in a patch or from user input). Both of these options don't seem
> very obvious/useful.
>
> Reported-by: viresh kumar<viresh.kumar@st.com>
> Signed-off-by: Stephen Boyd<bebarino@gmail.com>
Tested-by: Viresh Kumar <viresh.kumar@st.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git send-email doesn't take To: addresses from the patch
2010-09-01 8:56 ` viresh kumar
@ 2010-09-02 18:36 ` Stephen Boyd
2010-09-03 4:02 ` viresh kumar
2010-09-03 17:18 ` Junio C Hamano
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Boyd @ 2010-09-02 18:36 UTC (permalink / raw)
To: viresh kumar; +Cc: git@vger.kernel.org, Junio C Hamano
On Wed, Sep 1, 2010 at 1:56 AM, viresh kumar <viresh.kumar@st.com> wrote:
> On 9/1/2010 1:20 PM, Stephen Boyd wrote:
>> Subject: [PATCH] send-email: Use To: headers in patch files
>>
>> It's a minor annoyance when you take the painstaking time to setup To:
>> headers for each patch in a large series, and then go out to send the
>> series with git-send-email and watch git ignore the To: headers in the
>> patch files.
>>
>> Therefore, always add To: headers from a patch file to the To: headers
>> for that message. Keep the prompt for the blanket To: header so as to
>> not break scripts (and user expectations). This means even if a patch has a
>> To: header, git will prompt for the To: address. Otherwise, we'll need to
>> introduce interface breakage to either request the header for each patch
>> missing a To: header or default the header to whatever To: address is found
>> first (be it in a patch or from user input). Both of these options don't seem
>> very obvious/useful.
>>
>> Reported-by: viresh kumar<viresh.kumar@st.com>
>> Signed-off-by: Stephen Boyd<bebarino@gmail.com>
>
> Tested-by: Viresh Kumar <viresh.kumar@st.com>
>
Cool. Junio, does this look good to you? I can squash in some tests
later tonight if I get some git time.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git send-email doesn't take To: addresses from the patch
2010-09-02 18:36 ` Stephen Boyd
@ 2010-09-03 4:02 ` viresh kumar
2010-09-03 17:18 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: viresh kumar @ 2010-09-03 4:02 UTC (permalink / raw)
To: Stephen Boyd; +Cc: git@vger.kernel.org, Junio C Hamano
On 9/3/2010 12:06 AM, Stephen Boyd wrote:
> Cool. Junio, does this look good to you? I can squash in some tests
> later tonight if I get some git time.
It works perfectly fine for me.
thanks
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git send-email doesn't take To: addresses from the patch
2010-09-02 18:36 ` Stephen Boyd
2010-09-03 4:02 ` viresh kumar
@ 2010-09-03 17:18 ` Junio C Hamano
1 sibling, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2010-09-03 17:18 UTC (permalink / raw)
To: Stephen Boyd; +Cc: viresh kumar, git@vger.kernel.org
Stephen Boyd <bebarino@gmail.com> writes:
> On Wed, Sep 1, 2010 at 1:56 AM, viresh kumar <viresh.kumar@st.com> wrote:
>> On 9/1/2010 1:20 PM, Stephen Boyd wrote:
>>> Subject: [PATCH] send-email: Use To: headers in patch files
> ...
> Cool. Junio, does this look good to you? I can squash in some tests
> later tonight if I get some git time.
Sounds sane; thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-03 17:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 7:05 git send-email doesn't take To: addresses from the patch viresh kumar
2010-09-01 7:50 ` Stephen Boyd
2010-09-01 8:56 ` viresh kumar
2010-09-02 18:36 ` Stephen Boyd
2010-09-03 4:02 ` viresh kumar
2010-09-03 17:18 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).