git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: git-fast-import doc problem and git-fast-export does not quote filenames correctly
Date: Sat, 04 Sep 2010 21:48:58 +0200	[thread overview]
Message-ID: <4C82A2AA.3010408@alum.mit.edu> (raw)
In-Reply-To: <AANLkTimsVQ=mg2EUhUEO5ZWQMZoA72B=p2+1ZA=1qBtn@mail.gmail.com>

Sverre Rabbelier wrote:
> On Sat, Sep 4, 2010 at 01:17, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>> The first problem is that the doc seems to allow NUL bytes (which I
>> suspect are not really allowed)
> 
> Fast import keeps reading until it finds a '\n' and stores data in a
> strbuf, so I don't see why 'NUL' would not be allowed.

I guess I just found it hard to believe that git, with all of its
scripts, would really be able to handle NUL characters in filenames.
Moreover, even if git allows it, I think NUL is prohibited in posix
filenames, so it would be pretty pointless.

In the end, I asked this question to help figure out what filenames
"cvs2git" should allow through to git.  A NUL character could only get
into a CVS filename if the user writes some strange code to transform
the filename, so I guess I don't mind letting it through to git if there
is some chance that git can handle it.

> [...] Backslashes are allowed, and it seems they need to be escaped as
> usual. Perhaps Shawn can confirm that this should just be updated in
> the docs.

Thanks for the info!  Assuming that Shawn doesn't contradict you, I will
let any characters through and quote characters as you suggest.

Michael

      reply	other threads:[~2010-09-04 19:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04  6:17 git-fast-import doc problem and git-fast-export does not quote filenames correctly Michael Haggerty
2010-09-04 16:48 ` Sverre Rabbelier
2010-09-04 19:48   ` Michael Haggerty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C82A2AA.3010408@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).