From: Johannes Sixt <j.sixt@viscovery.net>
To: "Jan Krüger" <jk@jk.gs>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: [PATCH] read-tree: abort if no trees are given
Date: Fri, 10 Sep 2010 13:29:19 +0200 [thread overview]
Message-ID: <4C8A168F.1030502@viscovery.net> (raw)
In-Reply-To: <20100910120604.50aa1e94@jk.gs>
Am 9/10/2010 12:06, schrieb Jan Krüger:
> Currently, read-tree silently accepts an invocation without any
> tree-ishs given and simply clobbers the index in that case. This
> contradicts the usage synopsis and it's also probably not what anyone
> would want to happen. So, instead, abort with a fatal error.
See
http://thread.gmane.org/gmane.comp.version-control.git/135280/focus=135407
and the discussion that ensued; perhaps intersting is
http://thread.gmane.org/gmane.comp.version-control.git/135280/focus=135462
(where Junio suggest to make this a warning for now).
-- Hannes
next prev parent reply other threads:[~2010-09-10 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 10:06 [PATCH] read-tree: abort if no trees are given Jan Krüger
2010-09-10 11:29 ` Johannes Sixt [this message]
2010-09-10 13:28 ` [PATCH] read-tree: deprecate syntax without tree-ish args Jan Krüger
2010-09-10 13:53 ` Sverre Rabbelier
2010-09-10 15:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8A168F.1030502@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=jk@jk.gs \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).