From: Michael J Gruber <git@drmicha.warpmail.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2] remote-helpers: build in platform independent directory
Date: Sat, 18 Sep 2010 14:36:56 +0200 [thread overview]
Message-ID: <4C94B268.2050904@drmicha.warpmail.net> (raw)
In-Reply-To: <AANLkTi=ye=Xkz2XaiBaqX3NsZOe0N1NRTaVpPcsSM8o9@mail.gmail.com>
Sverre Rabbelier venit, vidit, dixit 17.09.2010 23:07:
> Heya,
>
> [+Jonathan again]
>
> On Fri, Sep 17, 2010 at 23:00, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> The solution with setup.cfg avoids this and is cleaner anyways.
>
> This does feel a lot cleaner, I like this approach better than the v1
> one. I suspect Junio's question still stands though:
>
> On Fri, Sep 17, 2010 at 20:41, Junio C Hamano <gitster@pobox.com> wrote:
>> Hmm, wouldn't this interfere with the install target if you do not tell
>> the "setup.py install" where your built stuff lives?
>
No, it addresses that also. Maybe my note after the boiler plate was not
clear enough, but the "build" setting in setup.cfg also governs the
build phase of "setup.py install". Install would work with v1 also but
would possibly create another dir during the build phase, with v2 both
build phases (that of the build subcommand as well as that of the
install subcommand) use the same setting.
Michael
prev parent reply other threads:[~2010-09-18 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 21:00 [PATCHv2] remote-helpers: build in platform independent directory Michael J Gruber
2010-09-17 21:07 ` Sverre Rabbelier
2010-09-18 12:36 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C94B268.2050904@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).