From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Clemens Buchacher <drizzd@aon.at>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3 v2] use cache for function names in hunk headers
Date: Mon, 27 Sep 2010 00:17:12 +0200 [thread overview]
Message-ID: <4C9FC668.8070701@lsrfire.ath.cx> (raw)
In-Reply-To: <20100926204318.GA19588@localhost>
Am 26.09.2010 22:43, schrieb Clemens Buchacher:
> On Sun, Sep 26, 2010 at 06:26:56PM +0200, René Scharfe wrote:
>> - /*
>> - * Be quite stupid about this for now. Find a line in the old file
>> - * before the start of the hunk (and context) which starts with a
>> - * plausible character.
>> - */
>>
>> It also removes an outdated comment.
>
> Actually, in the default case, the comment is still correct and
> helpful IMO.
The first sentence was probably written before the match function became
configurable. The second one could be moved to def_ff().
>> The inlining part should probably split out in its own patch..
>
> I am not sure what you mean here. Do you want to add the parameter
> funclineprev to the function and remove the function in the next
> page, or do you want to refactor the below into an inline function?
I'd suggest having a first patch for folding xdl_find_func() into
xdl_emit_diff() without any functional change (manually inlining it) and
a second one for adding funclineprev etc..
René
next prev parent reply other threads:[~2010-09-26 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 9:59 Patch id tests and diff performance optimization Clemens Buchacher
2010-09-19 9:59 ` [PATCH 1/3] add rebase patch id tests Clemens Buchacher
2010-09-19 9:59 ` [PATCH 2/3] do not search functions for patch ID Clemens Buchacher
2010-09-19 9:59 ` [PATCH 3/3] use cache for function names in hunk headers Clemens Buchacher
2010-09-19 20:24 ` Sverre Rabbelier
2010-09-20 17:36 ` Clemens Buchacher
2010-09-20 19:15 ` Sverre Rabbelier
2010-09-23 7:04 ` [PATCH 3/3 v2] " Clemens Buchacher
2010-09-26 16:26 ` René Scharfe
2010-09-26 20:43 ` Clemens Buchacher
2010-09-26 22:17 ` René Scharfe [this message]
2010-09-27 17:52 ` Junio C Hamano
2010-09-30 18:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9FC668.8070701@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).