git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Stephen Boyd <bebarino@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] Makefile: Add help target
Date: Tue, 28 Sep 2010 14:35:27 +0200	[thread overview]
Message-ID: <4CA1E10F.4080906@op5.se> (raw)
In-Reply-To: <AANLkTi=beUW5j4WSGOB__LNP7o60Wep_Y9n4YXOZUMtU@mail.gmail.com>

On 09/28/2010 01:37 PM, Sverre Rabbelier wrote:
> Heya,
> 
> On Tue, Sep 28, 2010 at 11:45, Junio C Hamano<gitster@pobox.com>  wrote:
>> I do not look forward to having to maintain a large number of lines that
>> are doomed to go stale
> 
> How often have we changed makefile targets recently? The most recent
> one that I can find is Jakub adding "install-gitweb" in 152d94348f,
> which was back in May 1st. The next one before that is the addition of
> 'gitweb' in 62331ef1637f which was back in January 30th. Besides,
> 'make help' doesn't have to contain _all_ Makefile targets, just the
> important ones that a user is most likely to need. Similar to 'git
> help' itself.
> 
>> and every time we need to touch we need to deal
>> with a lot of noise "@echo '"?
> 
> I don't understand what is particularly bothersome about the leading
> "@echo" lines. Adding or removing a target is still very easy even
> with the leading @echo's, the only thing that would be a PITA is
> reflowing paragraphs, currently, there _are_ no paragraphs, everything
> fits on one line.
> 
>> It might be a bit less distasteful if it were plain text additions at the
>> end of INSTALL file, though.
> 
> That does not help me nearly as much when I want to know how a
> makefile target is called. Am I wrong in asserting that having a "make
> help" target is an accepted "good practice" in the unix world?
> 

help:
    @echo Available make targets:
    @echo -----------------------
    @$(MAKE) --print-data-base --question | \
	sed -n -e '/^Makefile/d' -e 's/^\([a-z0-9_-]*\):.*/\1/p' | \
	sort | uniq | grep -v -e ^git -e ^test-

Automatically self-managing and seems to print most sensible targets.
Adjust to taste with whatever's appropriate.

Users with a too-old make program (pre 3.67, I think), won't be able
to use the help target, but that's perfectly acceptable imo.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

  reply	other threads:[~2010-09-28 12:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28  8:13 [PATCH] Makefile: Add help target Stephen Boyd
2010-09-28  9:45 ` Junio C Hamano
2010-09-28 11:37   ` Sverre Rabbelier
2010-09-28 12:35     ` Andreas Ericsson [this message]
2010-09-28 14:44       ` [PATCH] Makefile: implement " Michael J Gruber
2010-09-28 14:48         ` Sverre Rabbelier
2010-09-28 14:57           ` Zbyszek Szmek
2010-09-28 14:54         ` Ævar Arnfjörð Bjarmason
2010-09-28 15:33         ` Junio C Hamano
2010-09-28 15:47           ` Michael J Gruber
2010-09-28 16:04             ` Ævar Arnfjörð Bjarmason
2010-09-28 20:38               ` [PATCHv2] " Michael J Gruber
2010-09-28 20:51                 ` Sverre Rabbelier
2010-09-28 21:24                 ` Jakub Narebski
2010-09-28 22:00                 ` Brandon Casey
2010-09-29  8:06                   ` Michael J Gruber
2010-09-29  5:16                 ` Jeff King
2010-09-29  7:03                   ` Michael J Gruber
2010-09-29  7:34                     ` Jeff King
2010-09-29 15:41                       ` Junio C Hamano
2010-09-29 20:15                         ` [PATCHv3] " Michael J Gruber
2010-09-29 20:39                           ` Junio C Hamano
2010-09-30  7:08                             ` Michael J Gruber
2010-09-29  6:10   ` [PATCH] Makefile: Add " yj2133011
  -- strict thread matches above, loose matches on Subject: below --
2022-04-08  7:45 [PATCH] Makefile: add " Elia Pinto
2022-04-08  9:32 ` Philip Oakley
2022-04-08 15:30 ` Taylor Blau
2022-04-08 15:44   ` Ævar Arnfjörð Bjarmason
2022-04-08 18:58   ` Junio C Hamano
2010-08-25  9:51 [PATCH] Makefile: Add " Stephen Boyd
2010-08-25 16:27 ` Sverre Rabbelier
2010-08-25 21:36   ` Stephen Boyd
2010-08-25 21:39     ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA1E10F.4080906@op5.se \
    --to=ae@op5.se \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).