From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Stephen Boyd" <bebarino@gmail.com>,
"Andreas Ericsson" <ae@op5.se>,
"Sverre Rabbelier" <srabbelier@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCHv3] Makefile: implement help target
Date: Thu, 30 Sep 2010 09:08:21 +0200 [thread overview]
Message-ID: <4CA43765.5010804@drmicha.warpmail.net> (raw)
In-Reply-To: <7vbp7gmggy.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 09/29/2010 10:39 PM:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>> diff --git a/Makefile b/Makefile
>> index db2efd6..371214d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1,4 +1,10 @@
>> # The default target of this Makefile is...
>> +help-Build::
>
> Heh, no way. The default target of this Makefile should remain "all".
Damnit, that wasn't intended.... But that's solved by a simple
reordering, of course.
> Even though letting phony double-colon rules to implicitly collect members
> of groups and showing them is a neat idea, I do not think "make -j help"
> would do what you are expecting ;-)
I expect a randomly ordered mess, and "make -j help" fully meets those
expectations! Can "-j" be set in the environment or config.mak somehow?
Otherwise I think that explicitly shooting yourself in the foot should
be allowed...
Anyway, this topic is (only) about help on our Makefile, and I think
that as long as we don't want to go several extra miles, we have to
decide between two app roaches :)
* comment based:
+ readable
+ -j safe
- no var expansion (that I know of, at least without recursive make)
+- single line comments (unless more perl/awk foo is invested)
+- either in Makefile order or lexically sorted (or more perl lines)
* phony :: rules based:
+- somewhat less readable
- not -j safe
+ var expansion
+ multi line comments (could easily add a 3rd level also)
+ categories can be ordered freely (targets in Makefile order within)
Michael
next prev parent reply other threads:[~2010-09-30 7:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 8:13 [PATCH] Makefile: Add help target Stephen Boyd
2010-09-28 9:45 ` Junio C Hamano
2010-09-28 11:37 ` Sverre Rabbelier
2010-09-28 12:35 ` Andreas Ericsson
2010-09-28 14:44 ` [PATCH] Makefile: implement " Michael J Gruber
2010-09-28 14:48 ` Sverre Rabbelier
2010-09-28 14:57 ` Zbyszek Szmek
2010-09-28 14:54 ` Ævar Arnfjörð Bjarmason
2010-09-28 15:33 ` Junio C Hamano
2010-09-28 15:47 ` Michael J Gruber
2010-09-28 16:04 ` Ævar Arnfjörð Bjarmason
2010-09-28 20:38 ` [PATCHv2] " Michael J Gruber
2010-09-28 20:51 ` Sverre Rabbelier
2010-09-28 21:24 ` Jakub Narebski
2010-09-28 22:00 ` Brandon Casey
2010-09-29 8:06 ` Michael J Gruber
2010-09-29 5:16 ` Jeff King
2010-09-29 7:03 ` Michael J Gruber
2010-09-29 7:34 ` Jeff King
2010-09-29 15:41 ` Junio C Hamano
2010-09-29 20:15 ` [PATCHv3] " Michael J Gruber
2010-09-29 20:39 ` Junio C Hamano
2010-09-30 7:08 ` Michael J Gruber [this message]
2010-09-29 6:10 ` [PATCH] Makefile: Add " yj2133011
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA43765.5010804@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=ae@op5.se \
--cc=avarab@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).