git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: viresh kumar <viresh.kumar@st.com>
To: Junio C Hamano <gitster@pobox.com>,
	"bebarino@gmail.com" <bebarino@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] send-email: Clear To: field for every mail
Date: Mon, 4 Oct 2010 13:19:56 +0530	[thread overview]
Message-ID: <4CA98724.2020203@st.com> (raw)
In-Reply-To: <7v7hhya0yc.fsf@alter.siamese.dyndns.org>

On 10/04/2010 12:39 PM, Junio C Hamano wrote:
> Heh, are people who send patches with only S-o-b by your definition not
> testing their patches at all ;-)?  As far as I can tell, your patch
> applied to 'next' will break t9001 rather badly.
> 
> I agree there is a bug that you are trying to address in the series by
> Stephen that keeps adding To: address that is read from an earlier output
> of format-patch created with its --to option, but I do not think this is a
> right fix.  Have you tested sending a series with a plain format-patch
> output without extraneous To:, Cc: and such headers?
> 
> A normal send-email session takes the recipient address from either --to
> or interactively upfront, and then use those addresses kept in @to
> variable in the loop, repeatedly.  I do not see anything in your patch to
> avoid losing these addresses.

Junio, Stephan,

Ya! my patch wasn't good enough. I just tried to solve it the way it was done
for cc.

-- 
viresh

      reply	other threads:[~2010-10-04  7:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04  5:37 [PATCH] send-email: Clear To: field for every mail Viresh KUMAR
2010-10-04  7:05 ` [PATCH] send-email: Don't leak To: headers between patches Stephen Boyd
2010-10-04  7:11   ` Junio C Hamano
2010-10-04  7:15   ` Ævar Arnfjörð Bjarmason
2010-10-04  7:25     ` Ævar Arnfjörð Bjarmason
2010-10-04  8:00       ` Junio C Hamano
2010-10-04 18:55         ` Joe Perches
2010-10-04  7:09 ` [PATCH] send-email: Clear To: field for every mail Junio C Hamano
2010-10-04  7:49   ` viresh kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA98724.2020203@st.com \
    --to=viresh.kumar@st.com \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).