From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Lehmann Subject: Re: [PATCH v2 0/3] Teach fetch and pull to recursively fetch submodules too Date: Wed, 13 Oct 2010 22:06:15 +0200 Message-ID: <4CB61137.6030502@web.de> References: <4C7A819B.3000403@web.de> <7vocckhcb6.fsf@alter.siamese.dyndns.org> <778BC76C-FDFA-4EF0-AA94-6631272DEC02@sb.org> <89574F83-293C-4E3E-A99D-EB6CE6D47646@sb.org> <4C9221B6.7070807@web.de> <4C9351A7.7050609@web.de> <4C9359D4.2030109@viscovery.net> <4C935D77.3080008@web.de> <329A2E43-ADE3-467C-A2A6-24ACB9DF641E@sb.org> <4C953DE5.6020900@web.de> <4C963D00.9050207@web.de> <28BC3A45-D3CF-4A8C-A818-B92A9827C8FB@sb.org> <4CAB8DDF.8080004@web.de> <4CB0BFDB.7010503@web.de> <4CB5C6D8.1070108@xiplink.com> <4CB6093F.3040800@web.de> <1691DBFD-6075-479E-8847-EB4595BB9E10@sb.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marc Branchaud , Junio C Hamano , Git Mailing List To: Kevin Ballard X-From: git-owner@vger.kernel.org Wed Oct 13 22:06:33 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P67an-00055x-6f for gcvg-git-2@lo.gmane.org; Wed, 13 Oct 2010 22:06:29 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896Ab0JMUGS (ORCPT ); Wed, 13 Oct 2010 16:06:18 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:37802 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119Ab0JMUGR (ORCPT ); Wed, 13 Oct 2010 16:06:17 -0400 Received: from smtp01.web.de ( [172.20.0.243]) by fmmailgate01.web.de (Postfix) with ESMTP id 477E216ED9FC4; Wed, 13 Oct 2010 22:06:16 +0200 (CEST) Received: from [93.240.100.90] (helo=[192.168.178.29]) by smtp01.web.de with asmtp (WEB.DE 4.110 #24) id 1P67aa-0005zb-00; Wed, 13 Oct 2010 22:06:16 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 In-Reply-To: <1691DBFD-6075-479E-8847-EB4595BB9E10@sb.org> X-Sender: Jens.Lehmann@web.de X-Provags-ID: V01U2FsdGVkX1/LV2QHYxWmTK6TUBSIXSq6Uye6PL+w2Ta66Q/M cNa9SpKeA2T06Xr1n92ul5AU4VzOtrh/Xz9e/Vuy1KNf2KveRj dhRFUsLZYdRvZb27UWrw== Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Am 13.10.2010 21:34, schrieb Kevin Ballard: > On Oct 13, 2010, at 12:32 PM, Jens Lehmann wrote: > >>>> There are use cases like mine where automatic recursion is just the right >>>> thing to do. But I would be fine with having to turn the recursion on >>>> explicitly in the configuration if most people think recursion is not a >>>> desirable default. It would be really nice to hear from other submodule >>>> users what they think about that ... >>> >>> I tend to think that the right default for fetch is to employ the same level >>> of recursion that was used for the initial clone. So if the clone was made >>> with --recursive then fetch should default to using --recursive. >> >> That's a very interesting idea. > > I'm not sure it's correct though. For example, with my scenario every single submodule is required for a correct build, but most submodules should definitely not be updated unless their parent submodule updates its gitlink. So --recursive is recommended for `git clone`, but a non-recursive fetch would be the correct behavior going forward. For *your* use case it might not be correct, but for others it may very well be. We need to get more user stories like that to get an overview about what config options are useful and what might be reasonable defaults for them. And then we can decide what set of options and defaults to choose.