From: Jens Lehmann <Jens.Lehmann@web.de>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, gitster@pobox.com
Subject: Re: [RGC/PATCHv2] grep: submodule support
Date: Sat, 16 Oct 2010 17:54:59 +0200 [thread overview]
Message-ID: <4CB9CAD3.7060109@web.de> (raw)
In-Reply-To: <1287185204-843-1-git-send-email-judge.packham@gmail.com>
Am 16.10.2010 01:26, schrieb Chris Packham:
> Here is my updated grep support for submodules series.
Thanks Chris and Duy, I added this series to my git-submod-enhancements
repo on github and will give it some testing next week.
> Chris Packham (4):
> grep: output the path from cwd to worktree
> grep_cache: check pathspec first
> add test for git grep --recursive
Hmm, is it useful to add tests before adding the feature tested? I
thought it makes more sense to add them in the same commit or after
adding what is tested (e.g. to reduce the noise when bisecting
later). Or am I missing something here?
(And by the way: the test script should be executable)
> grep: add support for grepping in submodules
Nit: The commit message (5/5) talks about the old option name
"--recurse-submodules" instead of the "--recursive" the patch
is adding.
> Nguyễn Thái Ngọc Duy (1):
> worktree: provide better prefix to go back to original cwd
next prev parent reply other threads:[~2010-10-16 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 23:26 [RGC/PATCHv2] grep: submodule support Chris Packham
2010-10-15 23:26 ` [RFC/PATCHv2 1/5] worktree: provide better prefix to go back to original cwd Chris Packham
2010-10-16 18:42 ` Jonathan Nieder
2010-10-17 2:48 ` Chris Packham
2010-10-17 10:01 ` Nguyen Thai Ngoc Duy
2010-10-18 2:05 ` Chris Packham
2010-10-15 23:26 ` [RFC/PATCHv2 2/5] grep: output the path from cwd to worktree Chris Packham
2010-10-15 23:26 ` [RFC/PATCHv2 3/5] grep_cache: check pathspec first Chris Packham
2010-10-15 23:26 ` [RFC/PATCHv2 4/5] add test for git grep --recursive Chris Packham
2010-10-15 23:26 ` [RFC/PATCHv2 5/5] grep: add support for grepping in submodules Chris Packham
2010-10-17 10:28 ` Nguyen Thai Ngoc Duy
2010-10-18 2:01 ` Chris Packham
2010-10-18 3:37 ` Nguyen Thai Ngoc Duy
2010-10-16 15:54 ` Jens Lehmann [this message]
2010-10-17 2:13 ` [RGC/PATCHv2] grep: submodule support Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB9CAD3.7060109@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=judge.packham@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).