git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>, Kevin Ballard <kevin@sb.org>,
	Jon Seymour <jon.seymour@gmail.com>,
	Chris Packham <judge.packham@gmail.com>,
	Marc Branchaud <marcnarc@xiplink.com>
Subject: Re: [PATCH v3 0/3] Teach fetch and pull to recursively fetch submodules
Date: Thu, 11 Nov 2010 09:18:37 +0100	[thread overview]
Message-ID: <4CDBA6DD.4040701@web.de> (raw)
In-Reply-To: <20101111000538.GB14189@burratino>

Am 11.11.2010 01:05, schrieb Jonathan Nieder:
> Jens Lehmann wrote:
> 
>> * Should the "--submodule-prefix" option - which is only used internally
>>   now - be a hidden option to "git fetch"?
> 
> Yes.  (Any option that is useless outside scripts should be, imho.)

Ok, I will change that.

>> But nonetheless I think this patch series is ok for inclusion as it does
>> not change default behavior and gives people the opportunity to play with
>> recursive fetch/pull by enabling one of the introduced config options.
> 
> Except for the .gitmodules detail I mentioned, it looks good to me.
> Looking forward to trying it out.

Thanks!

  reply	other threads:[~2010-11-11  8:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 23:53 [PATCH v3 0/3] Teach fetch and pull to recursively fetch submodules Jens Lehmann
2010-11-10 23:54 ` [PATCH v3 1/3] fetch/pull: Add the --recurse-submodules option Jens Lehmann
2010-11-10 23:55 ` [PATCH v3 2/3] Add the 'fetch.recurseSubmodules' config setting Jens Lehmann
2010-11-11  0:02   ` Jonathan Nieder
2010-11-11  8:14     ` Jens Lehmann
2010-11-11  8:27       ` Jonathan Nieder
2010-11-11 18:31         ` Junio C Hamano
2010-11-11 19:00           ` Jonathan Nieder
2010-11-12 11:54             ` Jens Lehmann
2010-11-12 15:52               ` Jonathan Nieder
2010-11-12 19:48                 ` Jens Lehmann
2010-11-12 20:16                   ` Jonathan Nieder
2010-11-12 21:58                     ` Jens Lehmann
2010-11-12 11:40           ` Jens Lehmann
2010-11-10 23:55 ` [PATCH v3 3/3] Submodules: Add the "fetchRecurseSubmodules" config option Jens Lehmann
2010-11-11  0:05 ` [PATCH v3 0/3] Teach fetch and pull to recursively fetch submodules Jonathan Nieder
2010-11-11  8:18   ` Jens Lehmann [this message]
2010-11-12 12:54   ` [PATCH v4 1/3] fetch/pull: Add the --recurse-submodules option Jens Lehmann
2010-11-12 19:54     ` Jonathan Nieder
2010-11-12 20:22       ` Jens Lehmann
2010-12-09 21:16     ` Junio C Hamano
2010-12-09 23:07       ` Jens Lehmann
2010-12-10 17:30         ` Junio C Hamano
2010-12-10 18:03           ` Jens Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDBA6DD.4040701@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jon.seymour@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=judge.packham@gmail.com \
    --cc=kevin@sb.org \
    --cc=marcnarc@xiplink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).