From: Jiang Xin <worldhello.net@gmail.com>
To: git@vger.kernel.org, gitster@pobox.com
Subject: [PATCH] git apply: binary files differ can be applied with -pN (N>1).
Date: Wed, 24 Nov 2010 13:20:46 +0800 [thread overview]
Message-ID: <4CECA0AE.90505@gmail.com> (raw)
When patch file generated against two non-git directories using
'git diff --binary --no-index' without '--no-prefix', the patch
file has patch level greater then 1, and should be applied with
'-p2' option. But it does not work if there are binary differ
in the patch file, it is because in one case the patch level is
not properly handled.
Signed-off-by: Jiang Xin <jiangxin@ossxp.com>
---
builtin/apply.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 23c18c5..d603e37 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -1126,6 +1126,7 @@ static char *git_header_name(char *line, int llen)
* form.
*/
for (len = 0 ; ; len++) {
+ int nslash = p_value;
switch (name[len]) {
default:
continue;
@@ -1137,7 +1138,7 @@ static char *git_header_name(char *line, int llen)
char c = *second++;
if (c == '\n')
return NULL;
- if (c == '/')
+ if (c == '/' && --nslash <= 0)
break;
}
if (second[len] == '\n' && !memcmp(name, second, len)) {
--
1.7.3.2.245.g03276.dirty
next reply other threads:[~2010-11-24 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 5:20 Jiang Xin [this message]
2010-11-24 6:53 ` [PATCH] git apply: binary files differ can be applied with -pN (N>1) Jiang Xin
2010-11-24 17:20 ` Junio C Hamano
2010-11-25 1:46 ` Jiang Xin
2010-11-25 2:52 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CECA0AE.90505@gmail.com \
--to=worldhello.net@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).