From: Johannes Sixt <j.sixt@viscovery.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: Breaking t1510-repo-setup.sh tests in pu
Date: Fri, 26 Nov 2010 08:51:04 +0100 [thread overview]
Message-ID: <4CEF66E8.1050806@viscovery.net> (raw)
In-Reply-To: <AANLkTim1G__J6KAnd+pNmKWwEDTHexUSJU2E7=7WFZmp@mail.gmail.com>
Am 11/26/2010 3:45, schrieb Nguyen Thai Ngoc Duy:
> OK it's probably bashisms. I think it will pass if you run it with
> bash :-P I'll resend the series later without bash specific
> constructs.
Sure, it is. This:
GIT_DIR="$TRASH_DIRECTORY/2/.git" test_repo 2/sub
does not work the same way in all shells when test_repo is a shell
function. You have to export GIT_DIR explicitly before the function call.
(But since in this case, test_repo invokes its own subshell anyway, you
better do it in the function.)
-- Hannes
prev parent reply other threads:[~2010-11-26 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 9:56 Breaking t1510-repo-setup.sh tests in pu Ævar Arnfjörð Bjarmason
2010-11-25 11:40 ` Nguyen Thai Ngoc Duy
[not found] ` <AANLkTinhgMhrcMtPKL0aOrkeVgo8NE8Sq0fuPuCcbdbq@mail.gmail.com>
2010-11-26 2:45 ` Nguyen Thai Ngoc Duy
2010-11-26 7:51 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEF66E8.1050806@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).