From: "J.H." <warthog9@eaglescrag.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] gitweb: die_error (error handling) improvements
Date: Sun, 12 Dec 2010 18:17:12 -0800 [thread overview]
Message-ID: <4D058228.7040905@eaglescrag.net> (raw)
In-Reply-To: <20101213004259.9475.87376.stgit@localhost.localdomain>
On 12/12/2010 04:46 PM, Jakub Narebski wrote:
> The following two patch series changes improve error / exception
> handling in gitweb, preparing the way for gitweb output caching, but
> useful even without it.
>
> I'm sending this patch series early to gather feedback on possible
> ways of improving error / exception handling in gitweb.
Personally, instead of another band-aid over this problem, and adding
(or further legitimizing) goto statements inside gitweb I'd much *MUCH*
rather we actually put in the work to actually clean this up.
This is the direction I'm heading in, which I mentioned in an earlier
e-mail.
There are a *LOT* of disadvantages to the eval mechanism in perl. It's
the standard but gitweb is getting more and more complex, and eval is
simplistic. Couple that with the complexity and uncertainty that things
like goto add to the code, I would *MUCH* rather not see this series go
in, as I think it is the wrong approach to fixing this.
- John 'Warthog9' Hawley
next prev parent reply other threads:[~2010-12-13 2:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 0:46 [RFC PATCH 0/2] gitweb: die_error (error handling) improvements Jakub Narebski
2010-12-13 0:48 ` [RFC PATCH 1/2] gitweb: Go to DONE_REQUEST rather than DONE_GITWEB in die_error Jakub Narebski
2010-12-13 0:49 ` [RFC PATCH 2/2] gitweb: use eval + die for error (exception) handling Jakub Narebski
2010-12-13 2:17 ` J.H. [this message]
2010-12-13 7:55 ` [RFC PATCH 0/2] gitweb: die_error (error handling) improvements Jakub Narebski
2010-12-13 9:46 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D058228.7040905@eaglescrag.net \
--to=warthog9@eaglescrag.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).