native-style key bindings for gitk on Mac OS X

native-style key bindings for gitk on Mac OS X

[Hans-Christoph Steiner]

Hey all,

This is my first post here, hopefully I'm not doing anything  
stupid ;)  I use gitk on Debian, Ubuntu, and Mac OS X.  I'm big on  
having apps feel native on each platform. Currently gitk's key  
bindings are very GNU/Linux-ish when using gitk on Mac OS X.  I'd like  
to submit a patch to make gitk use native-style key bindings and re- 
use common key bindings.  F-keys are really rarely used on Mac OS X,  
so it drives me a little nuts using them in gitk/Mac OS X.

Before starting this, I just wanted to make sure this isn't some hotly  
debated political issue.

.hc


----------------------------------------------------------------------------

Man has survived hitherto because he was too ignorant to know how to  
realize his wishes.  Now that he can realize them, he must either  
change them, or perish.    -William Carlos Williams

Re: native-style key bindings for gitk on Mac OS X

[Andreas Ericsson]

On 12/12/2010 11:08 PM, Hans-Christoph Steiner wrote:
> 
> Hey all,
> 
> This is my first post here, hopefully I'm not doing anything stupid
> ;) I use gitk on Debian, Ubuntu, and Mac OS X. I'm big on having apps
> feel native on each platform. Currently gitk's key bindings are very
> GNU/Linux-ish when using gitk on Mac OS X. I'd like to submit a patch
> to make gitk use native-style key bindings and re-use common key
> bindings.

So long as the patch lets the original keys work (ie, people who are
used to them as they are now aren't suddenly hit by a nasty surprise),
I think it's a great idea.

> Before starting this, I just wanted to make sure this isn't some
> hotly debated political issue.
> 

It will be if the old keys stop working or all of a sudden do something
different. Especially if the new thing it does isn't exactly harmless
but the old thing was.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

Re: native-style key bindings for gitk on Mac OS X

[Hans-Christoph Steiner]

On Dec 13, 2010, at 3:30 AM, Andreas Ericsson wrote:

> On 12/12/2010 11:08 PM, Hans-Christoph Steiner wrote:
>>
>> Hey all,
>>
>> This is my first post here, hopefully I'm not doing anything stupid
>> ;) I use gitk on Debian, Ubuntu, and Mac OS X. I'm big on having apps
>> feel native on each platform. Currently gitk's key bindings are very
>> GNU/Linux-ish when using gitk on Mac OS X. I'd like to submit a patch
>> to make gitk use native-style key bindings and re-use common key
>> bindings.
>
> So long as the patch lets the original keys work (ie, people who are
> used to them as they are now aren't suddenly hit by a nasty surprise),
> I think it's a great idea.
>
>> Before starting this, I just wanted to make sure this isn't some
>> hotly debated political issue.
>>
>
> It will be if the old keys stop working or all of a sudden do  
> something
> different. Especially if the new thing it does isn't exactly harmless
> but the old thing was.


I think that's a good idea.  The only problem is Cmd-F5 (i.e. Reload)  
is already globally claimed in Mac OS X to turn on the accessibility  
voiceover reader.  So all you get is a robot voice reading your GUI to  
you.  This could be Ctrl-F5 instead, then it'd be the same as on GNU/ 
Linux.

.hc




----------------------------------------------------------------------------

"[T]he greatest purveyor of violence in the world today [is] my own  
government." - Martin Luther King, Jr.