From: Sergio Callegari <sergio.callegari@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] ident: die on bogus date format
Date: Mon, 13 Dec 2010 19:00:45 +0100 [thread overview]
Message-ID: <4D065F4D.1090807@gmail.com> (raw)
In-Reply-To: <20101213170225.GA16033@sigill.intra.peff.net>
Thanks for looking (and coding) into it!
For my usage case, a warning would be ok too. If the commit generates a warning,
one can notice the warning and --amend the commit.
One can perhaps have the warning now and maybe an
error from version 1.8, so: (i) we are sure that the different behavior does not
break anything and
(ii) there is time to move the fmt_ident up in the code so that it is invoked
earlier
(to avoid the burden of writing the commit message and then seeing the commit
aborted).
By the way, note that I got into the issue by trying to use --date forgetting
the time.
Don't know if it could make sense to accept the date with some default time in
this case.
Regards
Sergio
next prev parent reply other threads:[~2010-12-13 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 15:20 Git silently ignores --date when data is not in the correct format Sergio
2010-12-13 17:02 ` [PATCH/RFC] ident: die on bogus date format Jeff King
2010-12-13 18:00 ` Sergio Callegari [this message]
2010-12-15 21:53 ` Junio C Hamano
2010-12-21 1:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D065F4D.1090807@gmail.com \
--to=sergio.callegari@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).