[PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin

[PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin

[Ramsay Jones]

The first (setup) test attempts to create a file, using the
test_commit function, called 'i can has snapshot?'. On cygwin
(and MinGW) this fails with a "No such file or directory" error.
In order to fix the tests, we simply remove the '?' wildcard
from the name, since the purpose of these tests is not about
creating funny filenames.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/t9501-gitweb-standalone-http-status.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh
index 2487da1..18825af 100755
--- a/t/t9501-gitweb-standalone-http-status.sh
+++ b/t/t9501-gitweb-standalone-http-status.sh
@@ -16,7 +16,7 @@ code and message.'
 # snapshot settings
 
 test_expect_success 'setup' "
-	test_commit 'SnapshotTests' 'i can has snapshot?'
+	test_commit 'SnapshotTests' 'i can has snapshot'
 "
 
 
-- 
1.7.3

Re: [PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin

[Jakub Narebski]

Ramsay Jones wrote:
> 
> The first (setup) test attempts to create a file, using the
> test_commit function, called 'i can has snapshot?'. On cygwin
> (and MinGW) this fails with a "No such file or directory" error.
> In order to fix the tests, we simply remove the '?' wildcard
> from the name, since the purpose of these tests is not about
> creating funny filenames.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>

All right.

Acked-by: Jakub Narebski <jnareb@gmail.com>

BTW. if the test was about handling funny filenames (containing
leading, embedded and trailing space, +&@=<>"' characters), what
should we do instead?

> ---
>  t/t9501-gitweb-standalone-http-status.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh
> index 2487da1..18825af 100755
> --- a/t/t9501-gitweb-standalone-http-status.sh
> +++ b/t/t9501-gitweb-standalone-http-status.sh
> @@ -16,7 +16,7 @@ code and message.'
>  # snapshot settings
>  
>  test_expect_success 'setup' "
> -	test_commit 'SnapshotTests' 'i can has snapshot?'
> +	test_commit 'SnapshotTests' 'i can has snapshot'
>  "
>  
>  
> -- 
> 1.7.3
> 
> 
> 

-- 
Jakub Narebski
Poland

Re: [PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin

[Ramsay Jones]

Jakub Narebski wrote:
> Ramsay Jones wrote:
>> The first (setup) test attempts to create a file, using the
>> test_commit function, called 'i can has snapshot?'. On cygwin
>> (and MinGW) this fails with a "No such file or directory" error.
>> In order to fix the tests, we simply remove the '?' wildcard
>> from the name, since the purpose of these tests is not about
>> creating funny filenames.
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> 
> All right.
> 
> Acked-by: Jakub Narebski <jnareb@gmail.com>

Thanks.

> BTW. if the test was about handling funny filenames (containing
> leading, embedded and trailing space, +&@=<>"' characters), what
> should we do instead?

Hmm... dunno; take a look at t3600-rm.sh and t4135-apply-weird-filenames.sh
for inspiration? ;-)

Just FYI the "illegal" pathname characters in windows include:
    < > : " / \ | ? *
along with control chars from 0 - 31.
Also, you can't have any trailing spaces or periods.

ATB,
Ramsay Jones