From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: prohaska@zib.de
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: t0050-filesystem.sh unicode tests borked on dash shell
Date: Tue, 21 Dec 2010 19:53:25 +0000 [thread overview]
Message-ID: <4D1105B5.5070703@ramsay1.demon.co.uk> (raw)
I noticed recently that the unicode tests, when run by the dash shell,
have not been working as designed. (The tests *pass*, but they are
*not* testing what was intended)
In order to demonstrate, I added an "false &&" line after the touch in
test #8, so that (on Ubuntu):
$ ./t0050-filesystem -i
ok 1 - see what we expect
ok 2 - detection of case insensitive filesystem during repo init
ok 3 - detection of filesystem w/o symlink support during repo init
ok 4 - setup case tests
ok 5 - rename (case change)
ok 6 - merge (case change)
not ok 7 - add (with different case) # TODO known breakage
not ok - 8 setup unicode normalization tests
#
#
# test_create_repo unicode &&
# cd unicode &&
# touch "$aumlcdiar" &&
# false &&
# git add "$aumlcdiar" &&
# git commit -m initial &&
# git tag initial &&
# git checkout -b topic &&
# git mv $aumlcdiar tmp &&
# git mv tmp "$auml" &&
# git commit -m rename &&
# git checkout -f master
#
#
$ ls trash\ directory.t0050-filesystem/unicode/
\x61\xcc\x88
$ bash t0050-filesystem -i
ok 1 - see what we expect
ok 2 - detection of case insensitive filesystem during repo init
ok 3 - detection of filesystem w/o symlink support during repo init
ok 4 - setup case tests
ok 5 - rename (case change)
ok 6 - merge (case change)
not ok 7 - add (with different case) # TODO known breakage
not ok - 8 setup unicode normalization tests
#
#
# test_create_repo unicode &&
# cd unicode &&
# touch "$aumlcdiar" &&
# false &&
# git add "$aumlcdiar" &&
# git commit -m initial &&
# git tag initial &&
# git checkout -b topic &&
# git mv $aumlcdiar tmp &&
# git mv tmp "$auml" &&
# git commit -m rename &&
# git checkout -f master
#
#
$ ls trash\ directory.t0050-filesystem/unicode/ | od -x
0000000 cc61 0a88
0000004
So bash works fine and I can avoid the problem by running the tests, thus:
$ SHELL_PATH=/bin/bash make NO_SVN_TESTS=1 test
Since I have an older dash, I compiled dash from source (my dash git repo
claims:
$ git describe --tags
v0.5.6-24-gb61ab0b
), but the result was exactly the same.
I afraid I don't have time to investigate this further at the moment ...
ATB,
Ramsay Jones
next reply other threads:[~2010-12-21 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 19:53 Ramsay Jones [this message]
2010-12-21 20:27 ` [PATCH] t0050: fix printf format strings for portability Jonathan Nieder
2010-12-21 21:26 ` Junio C Hamano
2010-12-28 18:05 ` Ramsay Jones
2010-12-21 20:29 ` t0050-filesystem.sh unicode tests borked on dash shell Thomas Rast
2010-12-21 20:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1105B5.5070703@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).