From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>
Subject: Re: What's cooking in git.git (Jan 2011, #01; Tue, 4)
Date: Sat, 08 Jan 2011 18:40:02 +0000 [thread overview]
Message-ID: <4D28AF82.4040102@ramsay1.demon.co.uk> (raw)
In-Reply-To: <7vipy4dy8y.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
>
> * rj/test-fixes (2010-12-14) 4 commits
> - t4135-*.sh: Skip the "backslash" tests on cygwin
> - t3032-*.sh: Do not strip CR from line-endings while grepping on MinGW
> - t3032-*.sh: Pass the -b (--binary) option to sed on cygwin
> - t6038-*.sh: Pass the -b (--binary) option to sed on cygwin
>
> I don't think people on different vintage of Cygwin agreed they are good
> workarounds---please correct me if I am mistaken.
No, it was different vintages of MinGW not Cygwin. Well, to be more precise,
it is the different versions of sed that are installed in MinGW by the
msysGit installer. ;-)
I used msysGit-fullinstall-1.6.4-preview20090729.exe to install msysGit,
18 months ago, and my version of sed is quite old. However, these patches
(which were done mainly for the benefit of cygwin) were written assuming
the more recent sed version installed by a more recent msysGit installer.
(judging by commit ca02ad34.) In other words, the sed version on cygwin
is new enough to know about the -b (--binary) option and so is the more
recent msysGit installers (but I don't know exactly which version).
I can use my patch #14, which you didn't pick up, to run the above tests
on my old installation. (Johannes was the only other laggard identified
and he claims to be upgrading soon! :-D Yeah, I should too.)
So, unless Johannes can think of something I've missed, I think all of
these commits are good to go...
ATB,
Ramsay Jones
next prev parent reply other threads:[~2011-01-08 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:50 What's cooking in git.git (Jan 2011, #01; Tue, 4) Junio C Hamano
2011-01-05 0:01 ` jn/svn-fe (Re: What's cooking in git.git (Jan 2011, #01; Tue, 4)) Jonathan Nieder
2011-01-05 2:11 ` What's cooking in git.git (Jan 2011, #01; Tue, 4) Martin von Zweigbergk
2011-01-08 18:40 ` Ramsay Jones [this message]
2011-01-08 19:47 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D28AF82.4040102@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).