From: Guy Rouillier <guyr@burntmail.com>
To: Martin Langhoff <martin@laptop.org>
Cc: Emil Medve <Emilian.Medve@freescale.com>,
Jonathan Nieder <jrnieder@gmail.com>, git <git@vger.kernel.org>,
Pascal Obry <pascal@obry.net>, Clemens Buchacher <drizzd@aon.at>
Subject: Re: cvsimport still not working with cvsnt
Date: Fri, 14 Jan 2011 01:38:01 -0500 [thread overview]
Message-ID: <4D2FEF49.8070205@burntmail.com> (raw)
In-Reply-To: <AANLkTikreDJmUPfwNJ2ABivrafjvQNN6WrytNMAcse4A@mail.gmail.com>
On 1/10/2011 10:38 AM, Martin Langhoff wrote:
> On Mon, Jan 10, 2011 at 2:33 AM, Guy Rouillier<guyr@burntmail.com> wrote:
>> Here is my patch for accomplishing the above. As this is my first time
>> submitting a patch, please let me know the correct procedure if
>> submitting a diff here is not appropriate. Thanks.
>
> The concept of what the patch is doing is good, but I'd recommend
>
> @cvspasslocations = ($ENV{'HOME'}."/cvspass", $ENV{'HOME'}."/.cvs/cvspass")
>
> foreach $cvspass (@cvspasslocations) {
> open(...
>
> and forgo the "matching" test.
>
Martin, thanks for the reply. Have you had a chance to read the entire
thread? The matching test was suggested by Emil.
This is my first patch submission. What is the process for reaching
consensus?
--
Guy Rouillier
next prev parent reply other threads:[~2011-01-14 6:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 4:05 cvsimport still not working with cvsnt Guy Rouillier
2010-12-20 21:36 ` Jonathan Nieder
2010-12-21 22:09 ` Emil Medve
2010-12-22 5:43 ` Guy Rouillier
2011-01-10 7:33 ` Guy Rouillier
2011-01-10 15:38 ` Martin Langhoff
2011-01-14 6:38 ` Guy Rouillier [this message]
2011-01-14 7:44 ` Jonathan Nieder
2011-01-14 21:49 ` Junio C Hamano
2011-01-30 6:33 ` Guy Rouillier
2011-01-30 20:19 ` Martin Langhoff
2011-02-10 22:01 ` Junio C Hamano
2011-02-18 6:26 ` Guy Rouillier
2011-02-18 18:34 ` Junio C Hamano
2011-02-19 7:17 ` Guy Rouillier
2011-02-20 7:21 ` Junio C Hamano
2011-02-21 4:30 ` Guy Rouillier
2011-02-21 23:33 ` Junio C Hamano
2011-02-22 23:08 ` Junio C Hamano
2011-02-22 23:50 ` Martin Langhoff
2011-02-23 0:08 ` Guy Rouillier
2011-02-23 0:45 ` Junio C Hamano
2011-02-23 2:33 ` Guy Rouillier
2011-02-23 5:24 ` Junio C Hamano
2011-02-27 5:20 ` Guy Rouillier
2011-02-27 8:26 ` Junio C Hamano
2011-04-29 4:27 ` Guy Rouillier
2011-04-29 22:27 ` Jonathan Nieder
2011-05-01 5:33 ` Guy Rouillier
2011-05-01 18:44 ` Junio C Hamano
2011-02-23 0:42 ` Junio C Hamano
2011-02-24 3:14 ` Guy Rouillier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2FEF49.8070205@burntmail.com \
--to=guyr@burntmail.com \
--cc=Emilian.Medve@freescale.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=martin@laptop.org \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).