From: Mathias Lafeldt <misfire@debugon.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Anders Kaseorg <andersk@MIT.EDU>,
Paul Mackerras <paulus@samba.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] gitk: Take only numeric version components when computing $git_version
Date: Tue, 18 Jan 2011 10:12:06 +0100 [thread overview]
Message-ID: <4D355966.7090707@debugon.org> (raw)
In-Reply-To: <20110113192243.GA20625@burratino>
Jonathan Nieder wrote:
> [...]
> So after building from a tarball generated with "git archive", "git version"
> produces v1.7.4-rc1, producing errors from gitk, but after building
> from the git repo or a tarball generated with "make dist", the version
> is v1.7.4.rc1 (which gitk accepts).
>
> Anders's fix looks good to me for robustness reasons anyway, so
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
OK then. Junio? :)
> Maybe the substitution in GIT-VERSION-GEN should say something like
>
> VN=$(echo "$VN" | sed -e 's/-\([^r]\)/.\1/g')
>
> meaning the result for tagged rcs would not depend on whether git is
> present? Alternatively, DEF_VER could be set to v1.7.4.rc1, which
> does not seem as nice to me.
next prev parent reply other threads:[~2011-01-18 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 12:44 BUG: gitk fails to parse 1.7.4-rc0 version string Mathias Lafeldt
2011-01-07 0:42 ` [PATCH] gitk: Take only numeric version components when computing $git_version Anders Kaseorg
2011-01-11 13:46 ` Mathias Lafeldt
2011-01-13 19:22 ` Jonathan Nieder
2011-01-18 9:12 ` Mathias Lafeldt [this message]
2011-01-18 10:47 ` Paul Mackerras
2011-01-18 21:26 ` Junio C Hamano
2011-01-19 9:35 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D355966.7090707@debugon.org \
--to=misfire@debugon.org \
--cc=andersk@MIT.EDU \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).